You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/03/10 16:56:42 UTC

[GitHub] [hbase] saintstack opened a new pull request #1266: HBASE-23956 Use less resources running tests

saintstack opened a new pull request #1266: HBASE-23956 Use less resources running tests
URL: https://github.com/apache/hbase/pull/1266
 
 
   Add being able to configure netty thread counts. Enable socket reuse
   (should not have any impact).
   
   hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.java
    Rename the threads we create in here so they are NOT named same was
    threads created by Hadoop RPC.
   
   hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/DefaultNettyEventLoopConfig.java
   hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcClient.java
   hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncFSWAL.java
    Allow configuring eventloopgroup thread count (so can override for
    tests)
   
   hbase-examples/src/main/java/org/apache/hadoop/hbase/client/example/HttpProxyExample.java
    Enable socket resuse.
   
   hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java
    Enable socket resuse and config for how many threads to use.
   
   hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
   hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
   hbase-server/src/main/java/org/apache/hadoop/hbase/util/ModifyRegionUtils.java
    Thread name edit; drop the redundant 'Thread' suffix.
   
   hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HFileReplicator.java
    Make closeable and shutdown executor when called.
   
   hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
    Call close on HFileReplicator
   
   hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationBase.java
    HDFS creates lots of threads. Use less of it so less threads overall.
   
   hbase-server/src/test/resources/hbase-site.xml
   hbase-server/src/test/resources/hdfs-site.xml
    Constrain resources when running in test context.
   
   hbase-server/src/test/resources/log4j.properties
    Enable debug on netty to see netty configs in our log
   
   pom.xml
    Add system properties when we launch JVMs to constrain thread counts in
    tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #1266: HBASE-23956 Use less resources running tests

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1266: HBASE-23956 Use less resources running tests
URL: https://github.com/apache/hbase/pull/1266#issuecomment-597261408
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 31s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 23s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   5m 56s |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   5m 59s |  branch-2 passed  |
   | +0 :ok: |  spotbugs  |   1m 29s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |  25m 23s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 19s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   5m 56s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 42s |  The patch passed checkstyle in hbase-client  |
   | +1 :green_heart: |  checkstyle  |   0m 14s |  The patch passed checkstyle in hbase-procedure  |
   | +1 :green_heart: |  checkstyle  |   1m 20s |  hbase-server: The patch generated 0 new + 233 unchanged - 2 fixed = 233 total (was 235)  |
   | +1 :green_heart: |  checkstyle  |   0m 20s |  The patch passed checkstyle in hbase-mapreduce  |
   | +1 :green_heart: |  checkstyle  |   0m 54s |  The patch passed checkstyle in hbase-thrift  |
   | +1 :green_heart: |  checkstyle  |   0m 11s |  The patch passed checkstyle in hbase-rsgroup  |
   | +1 :green_heart: |  checkstyle  |   0m 10s |  The patch passed checkstyle in hbase-shell  |
   | +1 :green_heart: |  checkstyle  |   0m 12s |  The patch passed checkstyle in hbase-endpoint  |
   | +1 :green_heart: |  checkstyle  |   0m 15s |  The patch passed checkstyle in hbase-rest  |
   | +1 :green_heart: |  checkstyle  |   0m 14s |  The patch passed checkstyle in hbase-examples  |
   | +1 :green_heart: |  checkstyle  |   2m 35s |  root: The patch generated 0 new + 238 unchanged - 2 fixed = 238 total (was 240)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m 39s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  hadoopcheck  |  23m 47s |  Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
   | +1 :green_heart: |  findbugs  |  36m 41s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  asflicense  |   2m 34s |  The patch generated 1 ASF License warnings.  |
   |  |   | 127m 40s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1266 |
   | Optional Tests | dupname asflicense spotbugs findbugs hadoopcheck hbaseanti checkstyle xml |
   | uname | Linux ac3b4999f458 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / dacceba0c7 |
   | asflicense | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
   | Max. process+thread count | 84 (vs. ulimit of 10000) |
   | modules | C: hbase-client hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-rest hbase-examples . U: . |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] saintstack commented on issue #1266: HBASE-23956 Use less resources running tests

Posted by GitBox <gi...@apache.org>.
saintstack commented on issue #1266: HBASE-23956 Use less resources running tests
URL: https://github.com/apache/hbase/pull/1266#issuecomment-597763687
 
 
   Ok. Let me merge this. See if it helps w/ the OOME we are seeing around findbugs/spotbugs. Shout if you want amendments to the change you asked me do @Apache9  Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #1266: HBASE-23956 Use less resources running tests

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1266: HBASE-23956 Use less resources running tests
URL: https://github.com/apache/hbase/pull/1266#issuecomment-597469804
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 49s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 25s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   5m 23s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   3m  0s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   4m 31s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   6m 15s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 19s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   5m  7s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 12s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 12s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 24s |  patch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   6m 19s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   1m 15s |  root in the patch failed.  |
   |  |   |  43m 32s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1266 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 8970a5fcd8a4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / ee0ea33ad0 |
   | Default Java | 1.8.0_232 |
   | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt |
   |  Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/testReport/ |
   | Max. process+thread count | 641 (vs. ulimit of 10000) |
   | modules | C: hbase-client hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-rest hbase-examples . U: . |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] saintstack commented on issue #1266: HBASE-23956 Use less resources running tests

Posted by GitBox <gi...@apache.org>.
saintstack commented on issue #1266: HBASE-23956 Use less resources running tests
URL: https://github.com/apache/hbase/pull/1266#issuecomment-597457798
 
 
   Ok. I think I sorted it. Command-line arg wasn't so bad given we were passing generic for netty anyways but this is a bit better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #1266: HBASE-23956 Use less resources running tests

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1266: HBASE-23956 Use less resources running tests
URL: https://github.com/apache/hbase/pull/1266#issuecomment-597276870
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 30s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 22s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   5m 58s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   3m 21s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   4m 54s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   6m 50s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 22s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   5m 49s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 31s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 31s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 58s |  patch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   6m 33s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 114m 23s |  root in the patch failed.  |
   |  |   | 160m 51s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1266 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux ad88692371b7 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / dacceba0c7 |
   | Default Java | 1.8.0_232 |
   | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt |
   |  Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/testReport/ |
   | Max. process+thread count | 3597 (vs. ulimit of 10000) |
   | modules | C: hbase-client hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-rest hbase-examples . U: . |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache9 commented on a change in pull request #1266: HBASE-23956 Use less resources running tests

Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1266: HBASE-23956 Use less resources running tests
URL: https://github.com/apache/hbase/pull/1266#discussion_r390679841
 
 

 ##########
 File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/DefaultNettyEventLoopConfig.java
 ##########
 @@ -31,10 +30,16 @@
  */
 @InterfaceAudience.Private
 class DefaultNettyEventLoopConfig {
 
 Review comment:
   Or let's just remove this class. Move the creation of event loop into the NettyRpcClientConfigHelper directly and honor the hbase.netty.worker.count configuration when creating? Though a bit strange is that the Configuration passed in may change but at least it can avoid reading the configuration from system property...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #1266: HBASE-23956 Use less resources running tests

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1266: HBASE-23956 Use less resources running tests
URL: https://github.com/apache/hbase/pull/1266#issuecomment-597486269
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 44s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 24s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   5m 22s |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   5m 36s |  branch-2 passed  |
   | +0 :ok: |  spotbugs  |   1m 20s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |  22m 27s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 20s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   5m 18s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 32s |  hbase-client: The patch generated 1 new + 2 unchanged - 6 fixed = 3 total (was 8)  |
   | +1 :green_heart: |  checkstyle  |   0m 14s |  The patch passed checkstyle in hbase-procedure  |
   | +1 :green_heart: |  checkstyle  |   1m 13s |  hbase-server: The patch generated 0 new + 233 unchanged - 2 fixed = 233 total (was 235)  |
   | +1 :green_heart: |  checkstyle  |   0m 19s |  The patch passed checkstyle in hbase-mapreduce  |
   | +1 :green_heart: |  checkstyle  |   0m 38s |  The patch passed checkstyle in hbase-thrift  |
   | +1 :green_heart: |  checkstyle  |   0m 14s |  The patch passed checkstyle in hbase-rsgroup  |
   | +1 :green_heart: |  checkstyle  |   0m 12s |  The patch passed checkstyle in hbase-shell  |
   | +1 :green_heart: |  checkstyle  |   0m 13s |  The patch passed checkstyle in hbase-endpoint  |
   | +1 :green_heart: |  checkstyle  |   0m 17s |  The patch passed checkstyle in hbase-rest  |
   | +1 :green_heart: |  checkstyle  |   0m 14s |  The patch passed checkstyle in hbase-examples  |
   | -0 :warning: |  checkstyle  |   1m 42s |  root: The patch generated 1 new + 235 unchanged - 8 fixed = 236 total (was 243)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m 26s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  hadoopcheck  |  15m 37s |  Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
   | +1 :green_heart: |  findbugs  |  23m  9s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   2m 18s |  The patch does not generate ASF License warnings.  |
   |  |   |  96m 43s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1266 |
   | Optional Tests | dupname asflicense spotbugs findbugs hadoopcheck hbaseanti checkstyle xml |
   | uname | Linux d8afaf3de4ee 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / ee0ea33ad0 |
   | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt |
   | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
   | Max. process+thread count | 93 (vs. ulimit of 10000) |
   | modules | C: hbase-client hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-rest hbase-examples . U: . |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #1266: HBASE-23956 Use less resources running tests

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1266: HBASE-23956 Use less resources running tests
URL: https://github.com/apache/hbase/pull/1266#issuecomment-597760211
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 44s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 25s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   5m 38s |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   6m 11s |  branch-2 passed  |
   | +0 :ok: |  spotbugs  |  14m 34s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |  25m 18s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 20s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   5m 54s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 42s |  hbase-client: The patch generated 0 new + 2 unchanged - 6 fixed = 2 total (was 8)  |
   | +1 :green_heart: |  checkstyle  |   0m 16s |  The patch passed checkstyle in hbase-procedure  |
   | +1 :green_heart: |  checkstyle  |   1m 22s |  hbase-server: The patch generated 0 new + 230 unchanged - 5 fixed = 230 total (was 235)  |
   | +1 :green_heart: |  checkstyle  |   0m 20s |  The patch passed checkstyle in hbase-mapreduce  |
   | +1 :green_heart: |  checkstyle  |   0m 56s |  The patch passed checkstyle in hbase-thrift  |
   | +1 :green_heart: |  checkstyle  |   0m 11s |  The patch passed checkstyle in hbase-rsgroup  |
   | +1 :green_heart: |  checkstyle  |   0m 10s |  The patch passed checkstyle in hbase-shell  |
   | +1 :green_heart: |  checkstyle  |   0m 13s |  The patch passed checkstyle in hbase-endpoint  |
   | +1 :green_heart: |  checkstyle  |   0m 15s |  The patch passed checkstyle in hbase-rest  |
   | +1 :green_heart: |  checkstyle  |   0m 14s |  The patch passed checkstyle in hbase-examples  |
   | +1 :green_heart: |  checkstyle  |   2m 35s |  root: The patch generated 0 new + 232 unchanged - 11 fixed = 232 total (was 243)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m 39s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  hadoopcheck  |  23m 41s |  Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
   | +1 :green_heart: |  findbugs  |  37m  6s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   2m 36s |  The patch does not generate ASF License warnings.  |
   |  |   | 127m 57s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1266 |
   | Optional Tests | dupname asflicense spotbugs findbugs hadoopcheck hbaseanti checkstyle xml |
   | uname | Linux 1e1a417a6527 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / ee0ea33ad0 |
   | Max. process+thread count | 84 (vs. ulimit of 10000) |
   | modules | C: hbase-client hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-rest hbase-examples . U: . |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #1266: HBASE-23956 Use less resources running tests

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1266: HBASE-23956 Use less resources running tests
URL: https://github.com/apache/hbase/pull/1266#issuecomment-597756178
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 34s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  7s |  Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 28s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   6m  1s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   3m 43s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   4m 34s |  branch has no errors when building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 28s |  hbase-client in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 17s |  hbase-procedure in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 39s |  hbase-server in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 20s |  hbase-mapreduce in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 46s |  hbase-thrift in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 21s |  hbase-rsgroup in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 22s |  hbase-rest in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 21s |  hbase-examples in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 19s |  root in branch-2 failed.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 20s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   5m 58s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 44s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 44s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 29s |  patch has no errors when building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 27s |  hbase-client in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 16s |  hbase-procedure in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 39s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 19s |  hbase-mapreduce in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 47s |  hbase-thrift in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 22s |  hbase-rsgroup in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 23s |  hbase-rest in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 20s |  hbase-examples in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 19s |  root in the patch failed.  |
   ||| _ Other Tests _ |
   | -0 :warning: |  unit  |  77m 47s |  root in the patch failed.  |
   |  |   | 120m 29s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1266 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 81bd79e72241 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / ee0ea33ad0 |
   | Default Java | 2020-01-14 |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-procedure.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rsgroup.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-procedure.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rsgroup.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt |
   | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt |
   |  Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/testReport/ |
   | Max. process+thread count | 5541 (vs. ulimit of 10000) |
   | modules | C: hbase-client hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-rest hbase-examples . U: . |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] saintstack commented on issue #1266: HBASE-23956 Use less resources running tests

Posted by GitBox <gi...@apache.org>.
saintstack commented on issue #1266: HBASE-23956 Use less resources running tests
URL: https://github.com/apache/hbase/pull/1266#issuecomment-597688982
 
 
   Fix checkstyle and the test failure (related)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #1266: HBASE-23956 Use less resources running tests

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1266: HBASE-23956 Use less resources running tests
URL: https://github.com/apache/hbase/pull/1266#issuecomment-597777855
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 42s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  6s |  Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 31s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   5m 41s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   3m 21s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   4m 50s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   7m  2s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 20s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   5m 36s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 31s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 31s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 58s |  patch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   6m 37s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 115m 14s |  root in the patch failed.  |
   |  |   | 161m 54s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1266 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux f1f222596730 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / ee0ea33ad0 |
   | Default Java | 1.8.0_232 |
   | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt |
   |  Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/testReport/ |
   | Max. process+thread count | 3947 (vs. ulimit of 10000) |
   | modules | C: hbase-client hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-rest hbase-examples . U: . |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/3/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] saintstack merged pull request #1266: HBASE-23956 Use less resources running tests

Posted by GitBox <gi...@apache.org>.
saintstack merged pull request #1266: HBASE-23956 Use less resources running tests
URL: https://github.com/apache/hbase/pull/1266
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #1266: HBASE-23956 Use less resources running tests

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1266: HBASE-23956 Use less resources running tests
URL: https://github.com/apache/hbase/pull/1266#issuecomment-597474361
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 30s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  6s |  Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 25s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   6m 54s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   4m 12s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   5m  0s |  branch has no errors when building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 28s |  hbase-client in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 15s |  hbase-procedure in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 40s |  hbase-server in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 19s |  hbase-mapreduce in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 52s |  hbase-thrift in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 21s |  hbase-rsgroup in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 21s |  hbase-rest in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 20s |  hbase-examples in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 17s |  root in branch-2 failed.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 18s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   6m 40s |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m 10s |  the patch passed  |
   | +1 :green_heart: |  javac  |   4m 10s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 58s |  patch has no errors when building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 27s |  hbase-client in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 16s |  hbase-procedure in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 40s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 19s |  hbase-mapreduce in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 53s |  hbase-thrift in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 20s |  hbase-rsgroup in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 21s |  hbase-rest in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 20s |  hbase-examples in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 17s |  root in the patch failed.  |
   ||| _ Other Tests _ |
   | -0 :warning: |  unit  |  14m 22s |  root in the patch failed.  |
   |  |   |  58m 56s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1266 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 42777309a841 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / ee0ea33ad0 |
   | Default Java | 2020-01-14 |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-procedure.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rsgroup.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-procedure.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rsgroup.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt |
   | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt |
   |  Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/testReport/ |
   | Max. process+thread count | 525 (vs. ulimit of 10000) |
   | modules | C: hbase-client hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-rest hbase-examples . U: . |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/2/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache9 commented on a change in pull request #1266: HBASE-23956 Use less resources running tests

Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1266: HBASE-23956 Use less resources running tests
URL: https://github.com/apache/hbase/pull/1266#discussion_r390676375
 
 

 ##########
 File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/DefaultNettyEventLoopConfig.java
 ##########
 @@ -31,10 +30,16 @@
  */
 @InterfaceAudience.Private
 class DefaultNettyEventLoopConfig {
 
 Review comment:
   This is not the design...
   
   The design is to create a new EventLoop and make the code use it.
   
   Change a configuration to change the 'default' instance and then make the code use the 'default' instance seems strange...
   
   And also another anti pattern is that, we even do not have a Configuration instance here...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #1266: HBASE-23956 Use less resources running tests

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1266: HBASE-23956 Use less resources running tests
URL: https://github.com/apache/hbase/pull/1266#issuecomment-597261756
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 39s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  8s |  Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 25s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   7m  7s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   4m  5s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   4m 54s |  branch has no errors when building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 20s |  root in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 27s |  hbase-client in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 20s |  hbase-examples in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 20s |  hbase-mapreduce in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 17s |  hbase-procedure in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 22s |  hbase-rest in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 21s |  hbase-rsgroup in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 38s |  hbase-server in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 46s |  hbase-thrift in branch-2 failed.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 20s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   6m 19s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 59s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 59s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 54s |  patch has no errors when building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 28s |  hbase-client in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 17s |  hbase-procedure in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 40s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 21s |  hbase-mapreduce in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 50s |  hbase-thrift in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 20s |  hbase-rsgroup in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 22s |  hbase-rest in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 20s |  hbase-examples in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 20s |  root in the patch failed.  |
   ||| _ Other Tests _ |
   | -0 :warning: |  unit  |  82m 49s |  root in the patch failed.  |
   |  |   | 128m 23s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1266 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 4e26c8af1de3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / dacceba0c7 |
   | Default Java | 2020-01-14 |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-procedure.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rsgroup.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-procedure.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rsgroup.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt |
   | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt |
   |  Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/testReport/ |
   | Max. process+thread count | 5448 (vs. ulimit of 10000) |
   | modules | C: hbase-client hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-rest hbase-examples . U: . |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1266/1/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services