You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/11 19:18:47 UTC

[GitHub] [beam] htyleo edited a comment on pull request #15698: [BEAM-13013] Extend cross language expansion.

htyleo edited a comment on pull request #15698:
URL: https://github.com/apache/beam/pull/15698#issuecomment-940370691


   Thanks for working on this extension!
   
   It does seem cleaner to consolidate the methods on HandlerParams. For SQL implementation, what we actually need are:
   1) input names + types (ExternalTransform.InputsMap + MultiEdge.Input.Type)
   2) output type (ExternalTransform.OutputsMap + MultiEdge.Output.Type)
   3) payload (ExternalTransform.Payload)
   
   Other HandlerParams info (windowing strategy, coder, etc) are used to properly construct the resulting Components and Transform in ExpansionResponse. If we can come up with some helper functions/methods, we may not need to expose them and can make user's life easier.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org