You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2006/06/26 05:25:54 UTC
[Bug 4969] New: M::SA::Message::Node::find_parts() has useless recursive option
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4969
Summary: M::SA::Message::Node::find_parts() has useless recursive
option
Product: Spamassassin
Version: 3.1.3
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P5
Component: Libraries
AssignedTo: dev@spamassassin.apache.org
ReportedBy: felicity@apache.org
While working on implementing a rule suggestion that came up on the mailing
list, I was noticing that the recursive parameter as implemented by find_parts()
is rather useless -- if true (the default) all subchildren are searched (which
is what we usually want to do), however if false, no subchildren are searched
which means only the single part is looked at -- which we could easily do
without find_parts.
So I'm going to attach a patch shortly which changes the recursive == false
option to mean "look at the current part and any direct children, but do not
recurse further" which is really more of what I meant during the initial
implementation.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4969] [review] M::SA::Message::Node::find_parts() has useless recursive option
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4969
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 |can be committed
------- Additional Comments From spamassassin@dostech.ca 2006-07-09 21:58 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4969] [review] M::SA::Message::Node::find_parts() has useless recursive option
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4969
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From felicity@apache.org 2006-07-09 23:56 -------
Sending lib/Mail/SpamAssassin/Message/Node.pm
Transmitting file data .
Committed revision 420374.
:)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4969] [review] M::SA::Message::Node::find_parts() has useless recursive option
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4969
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes |needs 1
------- Additional Comments From jm@jmason.org 2006-06-29 09:30 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4969] [review] M::SA::Message::Node::find_parts() has useless recursive option
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4969
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|M::SA::Message::Node::find_p|[review]
|arts() has useless recursive|M::SA::Message::Node::find_p
|option |arts() has useless recursive
| |option
Status Whiteboard| |needs 2 votes
Target Milestone|Undefined |3.1.4
------- Additional Comments From felicity@apache.org 2006-06-26 03:26 -------
I'd like to see this get into 3.1 so that the option is actually usable. :)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4969] [review] M::SA::Message::Node::find_parts() has useless recursive option
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4969
------- Additional Comments From felicity@apache.org 2006-06-26 03:30 -------
Created an attachment (id=3559)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3559&action=view)
suggested patch
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.