[GitHub] mistercrunch commented on a change in pull request #6299: Make stacktraces available in many more cases

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #6299: Make stacktraces available in many more cases
URL: https://github.com/apache/incubator-superset/pull/6299#discussion_r231783472
 
 

 ##########
 File path: superset/assets/src/chart/chartReducer.js
 ##########
 @@ -56,6 +56,7 @@ export default function chartReducer(charts = {}, action) {
     [actions.CHART_RENDERING_FAILED](state) {
       return { ...state,
         chartStatus: 'failed',
+        chartStackTrace: action.stackTrace,
 
 Review comment:
   Good call, even though the logic of what renders is based on `chartStatus`, it's a good idea to not leave expired state in Redux

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org