[GitHub] [spark] xinrong-databricks commented on a change in pull request #35415: [SPARK-37507][SQL] Add a new SQL function to_binary

[GitBox <gi...@apache.org>]

xinrong-databricks commented on a change in pull request #35415:
URL: https://github.com/apache/spark/pull/35415#discussion_r803360535



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -2538,6 +2538,76 @@ case class Encode(value: Expression, charset: Expression)
     newLeft: Expression, newRight: Expression): Encode = copy(value = newLeft, charset = newRight)
 }
 
+/**
+ * Converts the input expression to a binary value based on the supplied format.
+ */
+// scalastyle:off line.size.limit
+@ExpressionDescription(
+  usage = """
+    _FUNC_(str[, fmt]) - Converts the input `str` to a binary value based on the supplied `fmt`.
+      By default, the binary format for conversion is "hex" if `fmt` is omitted.

Review comment:
       How do you think setting `hex` as the default format? There is another [reference](https://docs.snowflake.com/en/sql-reference/functions/to_binary.html) setting `hex` as the default format.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org