You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by lifanxi <gi...@git.apache.org> on 2016/03/17 07:53:53 UTC

[GitHub] flink pull request: [FLINK-3692] Fix quick start description for t...

GitHub user lifanxi opened a pull request:

    https://github.com/apache/flink/pull/1809

    [FLINK-3692] Fix quick start description for the ".timeWindow()" function call

    Jira Issue:
    https://issues.apache.org/jira/browse/FLINK-3629
    
    On Quick Start page (https://ci.apache.org/projects/flink/flink-docs-release-1.0/quickstart/run_example_quickstart.html).
    
    > The first call, .window(), specifies that we want to have tumbling (non-overlapping) windows of five seconds.
    
    This is not consistent with the sample code. In the sample code,
    ` KeyedStream.timeWindow() `
    function is used.
    
    So, change the document to say "The first call, .timeWindow() ...".


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lifanxi/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1809.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1809
    
----
commit b05d1fbc99fde984f0eb9668e89f8fda4c78d105
Author: 樊夕 <fa...@alibaba-inc.com>
Date:   2016-03-17T06:49:42Z

    [FLINK-3692] Fix quick start description for the ".timeWindow()" function call

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3629] Fix quick start description for t...

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/1809#issuecomment-197872846
  
    Thanks for the fix! :smile: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3629] Fix quick start description for t...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1809


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---