You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/12/07 02:21:59 UTC
[GitHub] [rocketmq] RongtongJin opened a new pull request #2492: [ISSUE# #2491] Temporary fix on Mac OS when pid greater than short type max value
RongtongJin opened a new pull request #2492:
URL: https://github.com/apache/rocketmq/pull/2492
## What is the purpose of the change
Temporary fix on Mac OS when pid greater than short type max value
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2492: [ISSUE# #2491] Temporary fix on Mac OS when pid greater than short type max value
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2492:
URL: https://github.com/apache/rocketmq/pull/2492#issuecomment-739628613
[](https://coveralls.io/builds/35488067)
Coverage increased (+0.09%) to 51.557% when pulling **81da164857ae2af9248715d39016a6b0137cc674 on RongtongJin:fix-test** into **7f49ce41f1663f47b55d843120f839b5ecb1d1bc on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ShannonDing merged pull request #2492: [ISSUE# #2491] Temporary fix on Mac OS when pid greater than short type max value
Posted by GitBox <gi...@apache.org>.
ShannonDing merged pull request #2492:
URL: https://github.com/apache/rocketmq/pull/2492
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-io commented on pull request #2492: [ISSUE# #2491] Temporary fix on Mac OS when pid greater than short type max value
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2492:
URL: https://github.com/apache/rocketmq/pull/2492#issuecomment-740366317
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2492?src=pr&el=h1) Report
> Merging [#2492](https://codecov.io/gh/apache/rocketmq/pull/2492?src=pr&el=desc) (7f49ce4) into [develop](https://codecov.io/gh/apache/rocketmq/commit/7f49ce41f1663f47b55d843120f839b5ecb1d1bc?el=desc) (7f49ce4) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq/pull/2492?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #2492 +/- ##
==========================================
Coverage 45.81% 45.81%
Complexity 4300 4300
==========================================
Files 547 547
Lines 36014 36014
Branches 4774 4774
==========================================
Hits 16499 16499
Misses 17452 17452
Partials 2063 2063
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2492?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2492?src=pr&el=footer). Last update [7f49ce4...81da164](https://codecov.io/gh/apache/rocketmq/pull/2492?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org