You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yileic <gi...@git.apache.org> on 2018/04/26 03:39:12 UTC
[GitHub] spark pull request #21162: shaded guava is not used anywhere, seems guava is...
GitHub user yileic opened a pull request:
https://github.com/apache/spark/pull/21162
shaded guava is not used anywhere, seems guava is not shaded anymore
## What changes were proposed in this pull request?
remove unused code to reduce confusion
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yileic/spark patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21162.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21162
----
commit d75b8bcc1c1b38a9cd04c81153cf1b1b865c5069
Author: yileic <ca...@...>
Date: 2018-04-26T03:36:40Z
shaded guava is not used anywhere, seems guava is not shaded anymore
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21162: shaded guava is not used anywhere, seems guava is not sh...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21162
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21162: shaded guava is not used anywhere, seems guava is not sh...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21162
Please close this PR. That is the rule that actual does shading of Guava, and we most definitely want to keep it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21162: shaded guava is not used anywhere, seems guava is not sh...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21162
CC @vanzin but it's more complex than that as far as I know. It is still shaded. You need to read https://spark.apache.org/contributing.html
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21162: shaded guava is not used anywhere, seems guava is...
Posted by yileic <gi...@git.apache.org>.
Github user yileic closed the pull request at:
https://github.com/apache/spark/pull/21162
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21162: shaded guava is not used anywhere, seems guava is not sh...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21162
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org