[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #295: fix snapshot check

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on PR #295:
URL: https://github.com/apache/incubator-pekko-http/pull/295#issuecomment-1667597954

   > I will try this again to see if I can create my own comparator for sbt.librarymanagement.VersionNumber
   
   Having an ordering number for a `VersionNumber` doesn't make sense in a library like sbt because its completely bespoke, different orgs have the option of making their own release strategies.
   
   In any case I would recommend how we approach this problem in general because there are issues in just using the latest snapshot as is done now, i.e. the builds are not deterministic which can be especially problematic if you are checking out past versions of pekko-http (i.e. trying to disect/figure out a bug) and instead of resolving the pekko version at that time you are instead resolving a completely different modern version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org