[GitHub] [incubator-echarts] quillblue commented on pull request #12859: feat: time axis label formatter

[GitBox <gi...@apache.org>]

quillblue commented on pull request #12859:
URL: https://github.com/apache/incubator-echarts/pull/12859#issuecomment-655922999


   @Ovilia Some additional thoughts based on this topic:
   ### Extend to Major/Minor axis ticks instead of use Primary/Secondary style
   This will help general customization on all geo coord axis ticks/labels not only simply specified to time axis. For time axis, user can use two formatter if they need. (more like the ways build charts in Microsoft Office)
   
   ### For i18n
   I would prefer to use any of external formatter (Moment for example) in callback, as various external time formatter have already provided enough functionality on culture/date preference/lanuange etc. This would also help seperate on format part and render part, which I think in axis component render is what need to be focused on. 
   For default formatter based on value, in my opinion may need to fully use of util to handle the transformation from date to text.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org