You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by mc...@apache.org on 2026/04/05 12:39:09 UTC
(hop) branch main updated: Fix Unable to open transform selection dialog via left-click in Hop GUI Pipeline (#6960)
This is an automated email from the ASF dual-hosted git repository.
mcasters pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hop.git
The following commit(s) were added to refs/heads/main by this push:
new 462ee02844 Fix Unable to open transform selection dialog via left-click in Hop GUI Pipeline (#6960)
462ee02844 is described below
commit 462ee028442902ba653725a87180a2a92ee1e94d
Author: Lance <le...@gmail.com>
AuthorDate: Sun Apr 5 20:39:03 2026 +0800
Fix Unable to open transform selection dialog via left-click in Hop GUI Pipeline (#6960)
Signed-off-by: lance <le...@gmail.com>
---
.../hop/testing/xp/LocationMouseDoubleClickExtensionPoint.java | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/plugins/misc/testing/src/main/java/org/apache/hop/testing/xp/LocationMouseDoubleClickExtensionPoint.java b/plugins/misc/testing/src/main/java/org/apache/hop/testing/xp/LocationMouseDoubleClickExtensionPoint.java
index e816c46299..d202f3b466 100644
--- a/plugins/misc/testing/src/main/java/org/apache/hop/testing/xp/LocationMouseDoubleClickExtensionPoint.java
+++ b/plugins/misc/testing/src/main/java/org/apache/hop/testing/xp/LocationMouseDoubleClickExtensionPoint.java
@@ -59,7 +59,6 @@ public class LocationMouseDoubleClickExtensionPoint
throws HopException {
HopGuiPipelineGraph pipelineGraph = pipelineGraphExtension.getPipelineGraph();
PipelineMeta pipelineMeta = pipelineGraph.getPipelineMeta();
- pipelineGraphExtension.setPreventingDefault(true);
PipelineUnitTest unitTest = TestingGuiPlugin.getCurrentUnitTest(pipelineMeta);
if (unitTest == null) {
@@ -81,7 +80,7 @@ public class LocationMouseDoubleClickExtensionPoint
}
}
- // Find the location that was double clicked on...
+ // Find the location that was double-clicked on...
//
MouseEvent e = pipelineGraphExtension.getEvent();
Point point = pipelineGraphExtension.getPoint();
@@ -93,12 +92,13 @@ public class LocationMouseDoubleClickExtensionPoint
//
if (DataSetConst.AREA_DRAWN_INPUT_DATA_SET.equals(areaOwner.getParent())) {
- // Open the dataset double clicked on...
+ // Open the dataset double-clicked on...
//
String transformName = (String) areaOwner.getOwner();
PipelineUnitTestSetLocation inputLocation = unitTest.findInputLocation(transformName);
if (inputLocation != null) {
+ pipelineGraphExtension.setPreventingDefault(true);
PipelineUnitTestSetLocationDialog dialog =
new PipelineUnitTestSetLocationDialog(
hopGui.getActiveShell(),
@@ -120,6 +120,7 @@ public class LocationMouseDoubleClickExtensionPoint
PipelineUnitTestSetLocation goldenLocation = unitTest.findGoldenLocation(transformName);
if (goldenLocation != null) {
+ pipelineGraphExtension.setPreventingDefault(true);
PipelineUnitTestSetLocationDialog dialog =
new PipelineUnitTestSetLocationDialog(
hopGui.getActiveShell(),
@@ -157,6 +158,7 @@ public class LocationMouseDoubleClickExtensionPoint
return;
}
+ pipelineGraphExtension.setPreventingDefault(true);
ValidatePipelineUnitTestExtensionPoint.showUnitTestErrors(pipeline, results, hopGui);
}
}