[GitHub] [hudi] lw309637554 commented on a change in pull request #2398: [HUDI-842] Implementation of HUDI RFC-15.

[GitBox <gi...@apache.org>]

lw309637554 commented on a change in pull request #2398:
URL: https://github.com/apache/hudi/pull/2398#discussion_r550972807



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -599,8 +606,14 @@ public HoodieCleanMetadata clean() {
    * Provides a new commit time for a write operation (insert/update/delete).
    */
   public String startCommit() {
+    // NOTE : Need to ensure that rollback is done before a new commit is started
+    if (rollbackPending) {
+      // Only rollback pending commit/delta-commits. Do not touch compaction commits
+      rollbackPendingCommits();
+    }
     String instantTime = HoodieActiveTimeline.createNewInstantTime();
-    startCommitWithTime(instantTime);
+    HoodieTableMetaClient metaClient = createMetaClient(true);

Review comment:
       after https://github.com/apache/hudi/pull/2136/files  merged, we will reuse the metaclient in AbstractHoodieWriteClient.java 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org