You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/06/28 22:26:47 UTC
[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #987: HDDS-1685. Recon: Add support for 'start' query param to containers…
bharatviswa504 commented on a change in pull request #987: HDDS-1685. Recon: Add support for 'start' query param to containers…
URL: https://github.com/apache/hadoop/pull/987#discussion_r298765130
##########
File path: hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerKeyService.java
##########
@@ -69,16 +74,20 @@
/**
* Return @{@link org.apache.hadoop.ozone.recon.api.types.ContainerMetadata}
- * for all the containers.
+ * for the containers starting from the given "prev-key" query param for the
+ * given "limit". The given "prev-key" is skipped from the results returned.
*
+ * @param limit max no. of containers to get.
+ * @param prevKey the containerID after which results are returned.
* @return {@link Response}
*/
@GET
public Response getContainers(
- @DefaultValue("-1") @QueryParam("limit") int limit) {
+ @DefaultValue(FETCH_ALL) @QueryParam(RECON_QUERY_LIMIT) int limit,
+ @DefaultValue("0") @QueryParam(RECON_QUERY_PREVKEY) long prevKey) {
Review comment:
Minor NIT: Can we have a variable for this default value too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org