You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/11/23 16:39:02 UTC
[GitHub] [nifi] mattyb149 opened a new pull request #4682: NIFI-7973: Add default precision and scale properties to remaining SQL-based components
mattyb149 opened a new pull request #4682:
URL: https://github.com/apache/nifi/pull/4682
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
Some SQL-based components were missing Default Precision and Default Scale properties, causing at least the Avro writer to fail using Oracle as the ResultSet returns zero for precision. Using these properties ensures a default precision/scale will be used when invalid precision/scale values are returned in the ResultSet
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on a change in pull request #4682: NIFI-7973: Add default precision and scale properties to remaining SQL-based components
Posted by GitBox <gi...@apache.org>.
markap14 commented on a change in pull request #4682:
URL: https://github.com/apache/nifi/pull/4682#discussion_r551502899
##########
File path: nifi-nar-bundles/nifi-extension-utils/nifi-database-utils/src/main/java/org/apache/nifi/util/db/JdbcProperties.java
##########
@@ -78,4 +77,15 @@
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
.required(true)
.build();
+
+ // Registry-only versions of Default Precision and Default Scale properties
+ public static final PropertyDescriptor REGISTRY_ONLY_DEFAULT_PRECISION =
Review comment:
I'm not sure that I understand what "registry" means in this context
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 closed pull request #4682: NIFI-7973: Add default precision and scale properties to remaining SQL-based components
Posted by GitBox <gi...@apache.org>.
markap14 closed pull request #4682:
URL: https://github.com/apache/nifi/pull/4682
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on a change in pull request #4682: NIFI-7973: Add default precision and scale properties to remaining SQL-based components
Posted by GitBox <gi...@apache.org>.
markap14 commented on a change in pull request #4682:
URL: https://github.com/apache/nifi/pull/4682#discussion_r552748170
##########
File path: nifi-nar-bundles/nifi-extension-utils/nifi-database-utils/src/main/java/org/apache/nifi/util/db/JdbcProperties.java
##########
@@ -78,4 +77,15 @@
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
.required(true)
.build();
+
+ // Registry-only versions of Default Precision and Default Scale properties
+ public static final PropertyDescriptor REGISTRY_ONLY_DEFAULT_PRECISION =
Review comment:
Ah, gotcha. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on a change in pull request #4682: NIFI-7973: Add default precision and scale properties to remaining SQL-based components
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on a change in pull request #4682:
URL: https://github.com/apache/nifi/pull/4682#discussion_r549832554
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTableRecord.java
##########
@@ -44,7 +44,7 @@
import java.util.List;
import java.util.Set;
-import static org.apache.nifi.processors.standard.util.JdbcProperties.USE_AVRO_LOGICAL_TYPES;
+import static org.apache.nifi.util.db.JdbcProperties.USE_AVRO_LOGICAL_TYPES;
Review comment:
I need to add the registry-only properties to this processor and change QueryDatabaseTable to use the registry-only properties as well. This will involve moving the registry-only properties out of the metrics utils class and into JdbcProperties
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on a change in pull request #4682: NIFI-7973: Add default precision and scale properties to remaining SQL-based components
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on a change in pull request #4682:
URL: https://github.com/apache/nifi/pull/4682#discussion_r552051653
##########
File path: nifi-nar-bundles/nifi-extension-utils/nifi-database-utils/src/main/java/org/apache/nifi/util/db/JdbcProperties.java
##########
@@ -78,4 +77,15 @@
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
.required(true)
.build();
+
+ // Registry-only versions of Default Precision and Default Scale properties
+ public static final PropertyDescriptor REGISTRY_ONLY_DEFAULT_PRECISION =
Review comment:
I'll change them to say `VARIABLE_REGISTRY_ONLY`, hopefully that makes it clearer that it is like the base property but doesn't support FlowFile attributes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #4682: NIFI-7973: Add default precision and scale properties to remaining SQL-based components
Posted by GitBox <gi...@apache.org>.
markap14 commented on pull request #4682:
URL: https://github.com/apache/nifi/pull/4682#issuecomment-759455390
Thanks @mattyb149 looks good to me. +1 merged to main!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org