You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "sisleyli (via GitHub)" <gi...@apache.org> on 2023/07/25 14:57:50 UTC
[GitHub] [tvm] sisleyli opened a new pull request, #15406: [TIR][BugFix]Ensure Var's scope is correct
sisleyli opened a new pull request, #15406:
URL: https://github.com/apache/tvm/pull/15406
In the previous bf16legalize pass, the `storage_scope` of the original BufferVar was not retained, but all changed to the default value (`global`). The purpose of this PR is to ensure that Var's scope is always correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Hzfengsy merged pull request #15406: [TIR][BugFix]Ensure the Var's scope is correct
Posted by "Hzfengsy (via GitHub)" <gi...@apache.org>.
Hzfengsy merged PR #15406:
URL: https://github.com/apache/tvm/pull/15406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sisleyli commented on pull request #15406: [TIR][BugFix]Ensure the Var's scope is correct
Posted by "sisleyli (via GitHub)" <gi...@apache.org>.
sisleyli commented on PR #15406:
URL: https://github.com/apache/tvm/pull/15406#issuecomment-1651240670
@Hzfengsy Done. Please take another look, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Hzfengsy commented on pull request #15406: [TIR][BugFix]Ensure the Var's scope is correct
Posted by "Hzfengsy (via GitHub)" <gi...@apache.org>.
Hzfengsy commented on PR #15406:
URL: https://github.com/apache/tvm/pull/15406#issuecomment-1654866436
Thanks @sisleyli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sisleyli commented on pull request #15406: [TIR][BugFix]Ensure Var's scope is correct
Posted by "sisleyli (via GitHub)" <gi...@apache.org>.
sisleyli commented on PR #15406:
URL: https://github.com/apache/tvm/pull/15406#issuecomment-1650010642
Hi @junrushao @masahi , could you help me review this PR? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sisleyli commented on pull request #15406: [TIR][BugFix]Ensure the Var's scope is correct
Posted by "sisleyli (via GitHub)" <gi...@apache.org>.
sisleyli commented on PR #15406:
URL: https://github.com/apache/tvm/pull/15406#issuecomment-1654836644
this PR has passed CI, could you please help me merge it? Thanks @Hzfengsy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #15406: [TIR][BugFix]Ensure Var's scope is correct
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #15406:
URL: https://github.com/apache/tvm/pull/15406#issuecomment-1650004820
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @Hzfengsy, @junrushao, @quic-sanirudh, @shingjan <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sisleyli commented on pull request #15406: [TIR][BugFix]Ensure the Var's scope is correct
Posted by "sisleyli (via GitHub)" <gi...@apache.org>.
sisleyli commented on PR #15406:
URL: https://github.com/apache/tvm/pull/15406#issuecomment-1652957191
@tvm-bot rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org