You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/04/06 17:41:52 UTC

[GitHub] [geode] fredster33 opened a new pull request #6272: Align logo, edit PR template

fredster33 opened a new pull request #6272:
URL: https://github.com/apache/geode/pull/6272


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [X] Does `gradlew build` run cleanly?
   
   - [X] Have you written or updated unit tests to verify your changes?
   
   - [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] fredster33 commented on pull request #6272: Align logo, edit PR template

Posted by GitBox <gi...@apache.org>.

fredster33 commented on pull request #6272:
URL: https://github.com/apache/geode/pull/6272#issuecomment-897237037


   Hi @upthewaterspout , and thanks for the question. Sorry, missed this in my inbox. I commented out, not removed, these sections, so that the guidance appears in the PR when contributors write the content for the PR description, but that the content doesn't appear when displaying after the PR has published. The content is still available when re-editing the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] upthewaterspout merged pull request #6272: Align logo, edit PR template

Posted by GitBox <gi...@apache.org>.

upthewaterspout merged pull request #6272:
URL: https://github.com/apache/geode/pull/6272


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] kohlmu-pivotal commented on pull request #6272: Align logo, edit PR template

Posted by GitBox <gi...@apache.org>.

kohlmu-pivotal commented on pull request #6272:
URL: https://github.com/apache/geode/pull/6272#issuecomment-826560900


   @pivotal-amurmann @upthewaterspout could you possibly have a look at this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] onichols-pivotal commented on pull request #6272: Align logo, edit PR template

Posted by GitBox <gi...@apache.org>.

onichols-pivotal commented on pull request #6272:
URL: https://github.com/apache/geode/pull/6272#issuecomment-917297785


   @upthewaterspout have your concerns now been addressed?  If so please change your -1 to a +1 and merge this, since submitter is not a committer.  If not, please restate what still needs to be changed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org