You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/18 07:13:11 UTC
[GitHub] [flink] JesseAtSZ commented on a diff in pull request #20091: [FLINK-27570][runtime]Count finalize failure in checkpoint manager
JesseAtSZ commented on code in PR #20091:
URL: https://github.com/apache/flink/pull/20091#discussion_r923029089
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java:
##########
@@ -1368,6 +1369,15 @@ private CompletedCheckpoint finalizeCheckpoint(PendingCheckpoint pendingCheckpoi
CheckpointFailureReason.FINALIZE_CHECKPOINT_FAILURE, e1));
}
+ if (e1 instanceof FlinkExpectedException) {
Review Comment:
Updated the PR, For some reasons, I can't compile successfully in my local(debugging).
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java:
##########
@@ -1368,6 +1369,15 @@ private CompletedCheckpoint finalizeCheckpoint(PendingCheckpoint pendingCheckpoi
CheckpointFailureReason.FINALIZE_CHECKPOINT_FAILURE, e1));
}
+ if (e1 instanceof FlinkExpectedException) {
Review Comment:
Updated the PR, for some reasons, I can't compile successfully in my local(debugging).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org