You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/02/07 18:16:56 UTC

[GitHub] mistercrunch opened a new pull request #4373: Remove dangerouslySetInnerHTML in StackTraceMessage component

mistercrunch opened a new pull request #4373: Remove dangerouslySetInnerHTML in StackTraceMessage component
URL: https://github.com/apache/incubator-superset/pull/4373
 
 
   Druid sometimes returns error message that are contained in "<>", as in
   `<urlopen error [Errno 61] Connection refused>`. Since Superset's
   approach is often to bubble up messages coming from external library,
   it's impossible to predict whether it will contain special characters.
   
   There are some cases where our error handling does return some html
   (presto?),
   but we should manage that upstream. Plus the current setup has security concerns,
   so let's move away from that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services