You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mattyb149 <gi...@git.apache.org> on 2018/08/14 18:57:20 UTC

[GitHub] nifi pull request #2950: NIFI-5517: Add support for remaining Hive types to ...

GitHub user mattyb149 opened a pull request:

    https://github.com/apache/nifi/pull/2950

    NIFI-5517: Add support for remaining Hive types to PutHive3Streaming

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-5517

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2950.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2950
    
----
commit 5118be13b0926e39e4ecd4004c18297c36a35fef
Author: Matthew Burgess <ma...@...>
Date:   2018-08-14T18:06:46Z

    NIFI-5517: Add support for remaining Hive types to PutHive3Streaming

----


---

[GitHub] nifi pull request #2950: NIFI-5517: Add support for remaining Hive types to ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/2950


---

[GitHub] nifi issue #2950: NIFI-5517: Add support for remaining Hive types to PutHive...

Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:

    https://github.com/apache/nifi/pull/2950
  
    Code LGTM and ran few tests against a running Hive 3 instance, it works as expected. Merging to master, thanks @mattyb149 


---