You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/27 08:52:05 UTC

[GitHub] [pulsar] codelipenghui opened a new pull request #7054: Add properties for managed-ledger.

codelipenghui opened a new pull request #7054:
URL: https://github.com/apache/pulsar/pull/7054


   ### Motivation
   
   Add properties for managed-ledger.
   
   ### Verifying this change
   
   New unit tests added
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat commented on pull request #7054: Add properties for managed-ledger.

Posted by GitBox <gi...@apache.org>.
merlimat commented on pull request #7054:
URL: https://github.com/apache/pulsar/pull/7054#issuecomment-637843729


   @codelipenghui @jiazhai There are multiple problems with this PR
   
    1.  It's not checking that there no other metadata operations in place. That will result in ZK bad version errors.
    2. It's writing the metadata without updating the in-memory version that the managed ledger keeps. This will result in a managed ledger fenced error each time a property is set, forcing the topic to get closed. 
    3. Why do we need to re-read the metadata from store? We already have that metadata and its corresponding version in memory.
   
   Finally, from the API is not clear what happens if there are already some properties and I just want to add a new one. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #7054: Add properties for managed-ledger.

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7054:
URL: https://github.com/apache/pulsar/pull/7054#issuecomment-638564431


   @merlimat Thanks for your comment, I will fix it later.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #7054: Add properties for managed-ledger.

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #7054:
URL: https://github.com/apache/pulsar/pull/7054


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui edited a comment on pull request #7054: Add properties for managed-ledger.

Posted by GitBox <gi...@apache.org>.
codelipenghui edited a comment on pull request #7054:
URL: https://github.com/apache/pulsar/pull/7054#issuecomment-638564431


   @merlimat Thanks for your comment, I will fix it later. I have created an issue to track this problem. https://github.com/apache/pulsar/issues/7161


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org