You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "dimas-b (via GitHub)" <gi...@apache.org> on 2025/02/08 02:13:59 UTC
[PR] Group application.properties by build time / run time [polaris]
dimas-b opened a new pull request, #970:
URL: https://github.com/apache/polaris/pull/970
As discussed in latest community meeting, having proprties that are settable only at build time can be surprising to Polaris users and contributors.
This change attempts to help with that matter by grouping build time properties into dedicated sections inside application.properties files and adding comments to clarify their usage.
<!--
Possible security vulnerabilities: STOP here and contact security@apache.org instead!
Please update the title of the PR with a meaningful message - do not leave it "empty" or "generated"
Please update this summary field:
The summary should cover these topics, if applicable:
* the motivation for the change
* a description of the status quo, for example the current behavior
* the desired behavior
* etc
PR checklist:
- Do a self-review of your code before opening a pull request
- Make sure that there's good test coverage for the changes included in this PR
- Run tests locally before pushing a PR (./gradlew check)
- Code should have comments where applicable. Particularly hard-to-understand
areas deserve good in-line documentation.
- Include changes and enhancements to the documentation (in site/content/in-dev/unreleased)
- For Work In Progress Pull Requests, please use the Draft PR feature.
Make sure to add the information BELOW this comment.
Everything in this comment will NOT be added to the PR description.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Group application.properties by build time / run time [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #970:
URL: https://github.com/apache/polaris/pull/970#issuecomment-2689024572
> Is there any reason to put the build properties first?
From my POV this is to make it clear what _cannot_ be changed in runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Group application.properties by build time / run time [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #970:
URL: https://github.com/apache/polaris/pull/970#issuecomment-2680776280
> One minor suggestion: can we move runtime configuration on the top of the build-time ones. Certain users may only care about the runtime configs, also build-time configs changes less frequently than runtime ones.
I'm not sure this change would be that helpful. People that run pre-built Polaris binaries, have no way to alter these files. On the other hand, people who build Polaris, would actually be interested in build-time properties, IMHO :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Group application.properties by build time / run time [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on PR #970:
URL: https://github.com/apache/polaris/pull/970#issuecomment-2688965767
> On the other hand, people who build Polaris, would actually be interested in build-time properties, IMHO :)
I think you're still more likely to want to change the runtime properties than the build properties. Is there any reason to put the build properties first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Group application.properties by build time / run time [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on PR #970:
URL: https://github.com/apache/polaris/pull/970#issuecomment-2689251104
> From my POV this is to make it clear what cannot be changed in runtime.
The chance of changing it is much less if they don't see it. It's a minor thing anyway. I will merge this one. We can always make changes later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Group application.properties by build time / run time [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain merged PR #970:
URL: https://github.com/apache/polaris/pull/970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org