You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@chemistry.apache.org by Michael Brackx <mi...@gmail.com> on 2012/10/23 14:22:35 UTC

tck - getContentChanges - latestChangeLogToken

Hi,

What should latestChangeLogToken be if getContentChanges returns no changes?

The spec says
"String latestChangeLogToken: The change log token corresponding to
the last change event in changeEvents."
However, changeEvents is empty, so there is no last change.

Currently I return null, but the tck checks for not null in
ContentChangesSmokeTest (line 65).
Maybe the tck should only do that check if changeEvents is not empty.

Michael

Re: tck - getContentChanges - latestChangeLogToken

Posted by Michael Brackx <mi...@gmail.com>.

Hi,

Thanks.
If changeEvents is empty i will return the changeLogToken from the request.
And if that is null, then latestChangeLogToken from getRepositoryInfo.

Michael

On Tue, Oct 23, 2012 at 5:54 PM, Florian Müller <fm...@apache.org> wrote:
> Hi Michael,
>
> The spec also says:
> "Repositories that support the changeLogToken event MUST expose the latest
> change log token (i.e. the change log token corresponding to the most recent
> change to any object in the repository) as a property returned by the
> getRepositoryInfo service."
>
> That sounds to me that the latestChangeLogToken must not be null if
> getContentChanges is supported.
>
> If there are no initial changes, you could return a token that expresses
> that.
>
>
> Florian
>
>
>
>
>> Hi,
>>
>> What should latestChangeLogToken be if getContentChanges returns no
>> changes?
>>
>> The spec says
>> "String latestChangeLogToken: The change log token corresponding to
>> the last change event in changeEvents."
>> However, changeEvents is empty, so there is no last change.
>>
>> Currently I return null, but the tck checks for not null in
>> ContentChangesSmokeTest (line 65).
>> Maybe the tck should only do that check if changeEvents is not empty.
>>
>> Michael
>
>

Re: tck - getContentChanges - latestChangeLogToken

Posted by Florian Müller <fm...@apache.org>.

 Hi Michael,

 The spec also says:
 "Repositories that support the changeLogToken event MUST expose the 
 latest change log token (i.e. the change log token corresponding to the 
 most recent change to any object in the repository) as a property 
 returned by the getRepositoryInfo service."

 That sounds to me that the latestChangeLogToken must not be null if 
 getContentChanges is supported.

 If there are no initial changes, you could return a token that 
 expresses that.


 Florian



> Hi,
>
> What should latestChangeLogToken be if getContentChanges returns no 
> changes?
>
> The spec says
> "String latestChangeLogToken: The change log token corresponding to
> the last change event in changeEvents."
> However, changeEvents is empty, so there is no last change.
>
> Currently I return null, but the tck checks for not null in
> ContentChangesSmokeTest (line 65).
> Maybe the tck should only do that check if changeEvents is not empty.
>
> Michael