You are viewing a plain text version of this content. The canonical link for it is here.

Posted to log4net-dev@logging.apache.org by rj2Skipper <gi...@git.apache.org> on 2016/09/05 14:05:47 UTC

[GitHub] log4net pull request #34: NewLinePatternConverter: fix Option==null crash

GitHub user rj2Skipper opened a pull request:

    https://github.com/apache/log4net/pull/34

    NewLinePatternConverter: fix Option==null crash

    check if Option is NULL before calling ToUpper
    fixes NullRef-Crash

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rj2Skipper/log4net trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/log4net/pull/34.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #34
    
----
commit 7091cca23b4f2ad000fd9a929ca3eee2067ed825
Author: Ralf J�nike <rj...@gmx.net>
Date:   2016-09-05T14:04:59Z

    fix Option==null crash
    
    check if Option is NULL before calling ToUpper
    fixes NullRef-Crash

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] log4net issue #34: NewLinePatternConverter: fix Option==null crash

Posted by bodewig <gi...@git.apache.org>.

Github user bodewig commented on the issue:

    https://github.com/apache/log4net/pull/34
  
    Thanks @rj2Skipper we've had about three alternative patches for this and I applied one with svn revision https://svn.apache.org/repos/asf/logging/log4net/trunk@1759541 which became commit 32b7a3e here.
    
    Could you please close this PR as I'm not able to do so on the github mirror myself.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] log4net issue #34: NewLinePatternConverter: fix Option==null crash

Posted by rj2Skipper <gi...@git.apache.org>.

Github user rj2Skipper commented on the issue:

    https://github.com/apache/log4net/pull/34
  
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] log4net pull request #34: NewLinePatternConverter: fix Option==null crash

Posted by rj2Skipper <gi...@git.apache.org>.

Github user rj2Skipper closed the pull request at:

    https://github.com/apache/log4net/pull/34


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---