You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/09/01 11:50:42 UTC

[GitHub] [superset] michael-s-molina commented on a diff in pull request #21269: feat: Adds a helper text option to the Select component

michael-s-molina commented on code in PR #21269:
URL: https://github.com/apache/superset/pull/21269#discussion_r960555342


##########
superset-frontend/src/components/Select/Select.tsx:
##########
@@ -162,6 +170,16 @@ const StyledLoadingText = styled.div`
   `}
 `;
 
+const StyledHelperText = styled.div`

Review Comment:
   Yes. I left it duplicated on purpose in this PR because @cccs-RyanK is already working on the common file in https://github.com/apache/superset/pull/21094



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org