You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Hemanth Yamijala <yh...@gmail.com> on 2016/05/30 18:07:51 UTC

Review Request 48050: ATLAS-503: Not all Hive tables are not imported into Atlas when interrupted with search queries while importing.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48050/
-----------------------------------------------------------

Review request for atlas and Suma Shivaprasad.


Bugs: ATLAS-503
    https://issues.apache.org/jira/browse/ATLAS-503


Repository: atlas


Description
-------

The patch implements retries in HBaseKeyColumnValueStore while acquiring locks within a JVM using the LocalLockMediator. The number of retries is configured using atlas.graph.storage.lock.retries. As described above, the value for this property should be equal to the desired level of parallelism. For e.g. if this is set to 10, it means that 10 concurrent operations can proceed to acquire locks on the same store, key and column.


Diffs
-----

  titan/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java b4dc12e 
  titan/src/test/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStoreTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/48050/diff/


Testing
-------

* Existing UTs and new UTs added here.
* Also set this configuration to 10 retries and verified that 10 concurrent users from JMeter can create traits in parallel.


Thanks,

Hemanth Yamijala


Re: Review Request 48050: ATLAS-503: Not all Hive tables are not imported into Atlas when interrupted with search queries while importing.

Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48050/#review135675
-----------------------------------------------------------


Ship it!




Ship It!

- Suma Shivaprasad


On May 30, 2016, 6:07 p.m., Hemanth Yamijala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48050/
> -----------------------------------------------------------
> 
> (Updated May 30, 2016, 6:07 p.m.)
> 
> 
> Review request for atlas and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-503
>     https://issues.apache.org/jira/browse/ATLAS-503
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> The patch implements retries in HBaseKeyColumnValueStore while acquiring locks within a JVM using the LocalLockMediator. The number of retries is configured using atlas.graph.storage.lock.retries. As described above, the value for this property should be equal to the desired level of parallelism. For e.g. if this is set to 10, it means that 10 concurrent operations can proceed to acquire locks on the same store, key and column.
> 
> 
> Diffs
> -----
> 
>   titan/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java b4dc12e 
>   titan/src/test/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStoreTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48050/diff/
> 
> 
> Testing
> -------
> 
> * Existing UTs and new UTs added here.
> * Also set this configuration to 10 retries and verified that 10 concurrent users from JMeter can create traits in parallel.
> 
> 
> Thanks,
> 
> Hemanth Yamijala
> 
>


Re: Review Request 48050: ATLAS-503: Not all Hive tables are not imported into Atlas when interrupted with search queries while importing.

Posted by Hemanth Yamijala <yh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48050/
-----------------------------------------------------------

(Updated June 1, 2016, 4:44 p.m.)


Review request for atlas and Suma Shivaprasad.


Changes
-------

Added configuration documentation.


Bugs: ATLAS-503
    https://issues.apache.org/jira/browse/ATLAS-503


Repository: atlas


Description
-------

The patch implements retries in HBaseKeyColumnValueStore while acquiring locks within a JVM using the LocalLockMediator. The number of retries is configured using atlas.graph.storage.lock.retries. As described above, the value for this property should be equal to the desired level of parallelism. For e.g. if this is set to 10, it means that 10 concurrent operations can proceed to acquire locks on the same store, key and column.


Diffs (updated)
-----

  distro/src/conf/atlas-application.properties bb12538 
  docs/src/site/twiki/Configuration.twiki f532a73 
  titan/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java b4dc12e 
  titan/src/test/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStoreTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/48050/diff/


Testing
-------

* Existing UTs and new UTs added here.
* Also set this configuration to 10 retries and verified that 10 concurrent users from JMeter can create traits in parallel.


Thanks,

Hemanth Yamijala