You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Yuting Gan (Jira)" <ji...@apache.org> on 2022/03/15 01:37:00 UTC

[jira] [Updated] (LUCENE-10467) Throws IllegalArgumentException for getAllDims if topN <= 0

     [ https://issues.apache.org/jira/browse/LUCENE-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yuting Gan updated LUCENE-10467:
--------------------------------
    Description: 
Currently, when calling getAllDims(0) in SortedSetDocValuesFacetCounts, it would throw a  NullPointerException. Other class that implements the getAllDims functionality could have the same issue, except for TaxonomyFacetCounts, which has been tested. 

It would provide better user experience by throwing an IllegalArgumentException when requesting topN <= 0 for getAllDims.

  was:
Currently, when calling getAllDims(0) in SortedSetDocValuesFacetCounts, it would throw a  NullPointerException. Other class that implements the getAllDims functionality could have the same issue, except for TaxonomyFacetCounts, which has been tested. 

It would provide better user experience by throwing an IllegalArgumentException when requesting topN = 0 for getAllDims.


> Throws IllegalArgumentException for getAllDims if topN <= 0
> -----------------------------------------------------------
>
>                 Key: LUCENE-10467
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10467
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>            Reporter: Yuting Gan
>            Priority: Minor
>
> Currently, when calling getAllDims(0) in SortedSetDocValuesFacetCounts, it would throw a  NullPointerException. Other class that implements the getAllDims functionality could have the same issue, except for TaxonomyFacetCounts, which has been tested. 
> It would provide better user experience by throwing an IllegalArgumentException when requesting topN <= 0 for getAllDims.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org