[GitHub] [helix] qqu0127 commented on a change in pull request #1988: Implement deactivate rest API

[GitBox <gi...@apache.org>]

qqu0127 commented on a change in pull request #1988:
URL: https://github.com/apache/helix/pull/1988#discussion_r828554182



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java
##########
@@ -243,6 +243,18 @@ public Response updateCluster(@PathParam("clusterId") String clusterId,
         }
         break;
 
+      case deactivate:
+        if (superCluster == null) {

Review comment:
       I followed the same pattern as `activate`, but just noticed there is a cluster check for activate, but not for deactivate. Will add that check. Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org