You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@spark.apache.org by "Sean Owen (JIRA)" <ji...@apache.org> on 2015/07/09 22:46:05 UTC

[jira] [Commented] (SPARK-8960) Style cleanup of spark_ec2.py

    [ https://issues.apache.org/jira/browse/SPARK-8960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621235#comment-14621235 ] 

Sean Owen commented on SPARK-8960:
----------------------------------

So, can I sort of hijack this to continue the thread about moving this and the mesos-based Spark EC2 scripts into a separate repo? then you and whoever wishes to maintain it could have it much more liberally.

> Style cleanup of spark_ec2.py
> -----------------------------
>
>                 Key: SPARK-8960
>                 URL: https://issues.apache.org/jira/browse/SPARK-8960
>             Project: Spark
>          Issue Type: Task
>          Components: EC2
>    Affects Versions: 1.4.0
>            Reporter: Daniel Darabos
>            Priority: Trivial
>
> The spark_ec2.py script could use some cleanup I think. There are simple style issues like mixing single and double quotes, but also some rather un-Pythonic constructs (e.g. https://github.com/apache/spark/pull/6336#commitcomment-12088624 that sparked this JIRA). Whenever I read it, I always find something that is too minor for a pull request/JIRA, but I'd fix it if it was my code. Perhaps we can address such issues in this JIRA.
> The intention is not to introduce any behavioral changes. It's hard to verify this without testing, so perhaps we should also add some kind of test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org