[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #5010: Core, API: Append changes to branch Impl

[GitBox <gi...@apache.org>]

amogh-jahagirdar commented on code in PR #5010:
URL: https://github.com/apache/iceberg/pull/5010#discussion_r895962748


##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -116,6 +118,14 @@ public ThisT scanManifestsWith(ExecutorService executorService) {
     return self();
   }
 
+  @Override
+  public ThisT toBranch(String branch){
+      Preconditions.checkArgument(branch != null,"branch cannot be null");
+      Preconditions.checkArgument(ops.current().ref(branch) != null, "%s is not a valid ref", branch);

Review Comment:
   I think there should be another validation that this ref is actually a branch. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org