You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/23 12:36:15 UTC

[GitHub] [shardingsphere] strongduanmu opened a new pull request #6178: support replace statement

strongduanmu opened a new pull request #6178:
URL: https://github.com/apache/shardingsphere/pull/6178


   Fixes #5330 .
   
   Changes proposed in this pull request:
   - support replace statement by insert statement
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on pull request #6178: support replace statement

Posted by GitBox <gi...@apache.org>.

strongduanmu commented on pull request #6178:
URL: https://github.com/apache/shardingsphere/pull/6178#issuecomment-648558879


   > Hi, @strongduanmu. Your PR seems what we expected. I like it! Thanks for your effort. Besides, could you add some SQL rewritten tests in [Insert SQLs](https://github.com/apache/shardingsphere/blob/master/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-rewrite/src/test/resources/sharding/insert.xml) to guarantee `Replace` SQL can be parsed, rewritten correctly?
   > 
   > @tuohai666 IMO, this PR also need your review, could you give it a careful look?
   
   @tristaZero Thanks for your review, I will add some SQL rewritten test cases. 😀


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #6178: support replace statement

Posted by GitBox <gi...@apache.org>.

tristaZero merged pull request #6178:
URL: https://github.com/apache/shardingsphere/pull/6178


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org