You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/10/12 05:26:57 UTC
[GitHub] [incubator-echarts] yufeng04 commented on a change in pull request #13416: feat(gauge): modify some default values, support svg pointer, add axisLine.distance/splitLine.distance/progress/anchor/data[i].title/data[i].detail #13216
yufeng04 commented on a change in pull request #13416:
URL: https://github.com/apache/incubator-echarts/pull/13416#discussion_r503045580
##########
File path: src/util/types.ts
##########
@@ -795,6 +795,7 @@ export interface LineStyleOption<Clr = ZRColor> extends ShadowOptionMixin {
join?: CanvasLineJoin
dashOffset?: number
miterLimit?: number
+ roundCap?: boolean
Review comment:
Thanks! I forget to delete it.
##########
File path: src/chart/gauge/GaugeView.ts
##########
@@ -95,25 +99,26 @@ class GaugeView extends ChartView {
posInfo: PosInfo
) {
const group = this.group;
-
- const axisLineModel = seriesModel.getModel('axisLine');
- const lineStyleModel = axisLineModel.getModel('lineStyle');
-
const clockwise = seriesModel.get('clockwise');
let startAngle = -seriesModel.get('startAngle') / 180 * Math.PI;
let endAngle = -seriesModel.get('endAngle') / 180 * Math.PI;
+ const axisLineModel = seriesModel.getModel('axisLine');
+
+ const roundCap = axisLineModel.get('roundCap');
+ const MainPath = roundCap ? Sausage : graphic.Sector;
Review comment:
There is a little difference between setting shape.cornerRadius/shape.innerCornerRadius and `roundCap`(Sausage).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org