[jira] Commented: (SHINDIG-355) OAuth in gadget xml spec

["Chris Chabot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609848#action_12609848 ] 

Chris Chabot commented on SHINDIG-355:
--------------------------------------

	public function hashCode()
	{
		$prime = 31;
		$result = 1;
		$result = $prime * $result + (($gadgetUri == null) ? 0 : $gadgetUri->hashCode());
		$result = $prime * $result + (int)($moduleId ^ ($moduleId >> 32));
		$result = $prime * $result + (($serviceName == null) ? 0 : $serviceName->hashCode());
		$result = $prime * $result + (($tokenName == null) ? 0 : $tokenName->hashCode());
		$result = $prime * $result + (($userId == null) ? 0 : $userId->hashCode());
		return $result;
	}

What's wrong with that function? that those vars are always null ... since you probably meant to do $this->gadgetUri etc? :-)

> OAuth in gadget xml spec 
> -------------------------
>
>                 Key: SHINDIG-355
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-355
>             Project: Shindig
>          Issue Type: New Feature
>          Components: Gadget Rendering Server (PHP)
>            Reporter: Chris Chabot
>         Attachments: feature-SHINDIG-355.patch
>
>
> Instead of having a new oauth feature, the proposal is to put it directly into the gadget xml spec. Should parse and support the oauth feature.
> See: http://www.google.com/url?q=http://groups.google.com/group/opensocial-and-gadgets-spec/browse_frm/thread/a1ce63eecfb21cad&sa=D&usg=ALhdy2-tUxagajVfd0hx98L5CubK3S340Q

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.