You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/05 06:46:53 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27460:
[SPARK-30733][R][HOTFIX] Fix SparkR tests per testthat and R version upgrade
dongjoon-hyun commented on a change in pull request #27460: [SPARK-30733][R][HOTFIX] Fix SparkR tests per testthat and R version upgrade
URL: https://github.com/apache/spark/pull/27460#discussion_r375082879
##########
File path: R/run-tests.sh
##########
@@ -31,8 +31,9 @@ NUM_TEST_WARNING="$(grep -c -e 'Warnings ----------------' $LOGFILE)"
# Also run the documentation tests for CRAN
CRAN_CHECK_LOG_FILE=$FWDIR/cran-check.out
rm -f $CRAN_CHECK_LOG_FILE
-
-NO_TESTS=1 NO_MANUAL=1 $FWDIR/check-cran.sh 2>&1 | tee -a $CRAN_CHECK_LOG_FILE
+# TODO(SPARK-30737) reenable this once packages are correctly installed in Jenkins
+touch $CRAN_CHECK_LOG_FILE
+# NO_TESTS=1 NO_MANUAL=1 $FWDIR/check-cran.sh 2>&1 | tee -a $CRAN_CHECK_LOG_FILE
Review comment:
This reminds me the following. :)
- 91d990162f ([SPARK-24152][R][TESTS] Disable check-cran from run-tests.sh)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org