You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/04/05 14:53:58 UTC

[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2234: FINERACT-1561 Client and Loan APIs enhancements

josehernandezfintecheandomx opened a new pull request, #2234:
URL: https://github.com/apache/fineract/pull/2234

   ## Description
   
   In attention to the next tickets:
   
   [Apache Fineract JIRA ticket 1559](https://issues.apache.org/jira/browse/FINERACT-1559)
   [Apache Fineract JIRA ticket 1560](https://issues.apache.org/jira/browse/FINERACT-1560)
   [Apache Fineract JIRA ticket 1561](https://issues.apache.org/jira/browse/FINERACT-1561).
   
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
   
   - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   
   - [ ] Create/update unit or integration tests for verifying the changes made.
   
   - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)
   
   FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2234: FINERACT-1561 Client and Loan APIs enhancements

Posted by GitBox <gi...@apache.org>.
josehernandezfintecheandomx commented on code in PR #2234:
URL: https://github.com/apache/fineract/pull/2234#discussion_r842882797


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/api/DataTableApiConstant.java:
##########
@@ -34,4 +34,25 @@ private DataTableApiConstant() {
     public static final String localParamName = "locale";
     public static final String DATATABLE_RESOURCE_NAME = "dataTables";
 
+    public static final String createdAtFieldName = "created_at";

Review Comment:
   Solved



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] josehernandezfintecheandomx closed pull request #2234: FINERACT-1561 Client and Loan APIs enhancements

Posted by GitBox <gi...@apache.org>.
josehernandezfintecheandomx closed pull request #2234: FINERACT-1561 Client and Loan APIs enhancements
URL: https://github.com/apache/fineract/pull/2234


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] josehernandezfintecheandomx closed pull request #2234: FINERACT-1561 Client and Loan APIs enhancements

Posted by GitBox <gi...@apache.org>.
josehernandezfintecheandomx closed pull request #2234: FINERACT-1561 Client and Loan APIs enhancements
URL: https://github.com/apache/fineract/pull/2234


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] josehernandezfintecheandomx commented on pull request #2234: FINERACT-1561 Client and Loan APIs enhancements

Posted by GitBox <gi...@apache.org>.
josehernandezfintecheandomx commented on PR #2234:
URL: https://github.com/apache/fineract/pull/2234#issuecomment-1098157165

   Included in other PR https://github.com/apache/fineract/pull/2279


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2234: FINERACT-1561 Client and Loan APIs enhancements

Posted by GitBox <gi...@apache.org>.
josehernandezfintecheandomx commented on code in PR #2234:
URL: https://github.com/apache/fineract/pull/2234#discussion_r842883075


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java:
##########
@@ -1637,6 +1658,10 @@ private String getUpdateSql(List<ResultsetColumnHeaderData> columnHeaders, final
                     }
                 }
                 sql += sqlGenerator.escape(key) + " = " + pValueWrite;
+            } else {
+                if (key.equalsIgnoreCase("updated_at")) {

Review Comment:
   Solved



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] galovics commented on a diff in pull request #2234: FINERACT-1561 Client and Loan APIs enhancements

Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2234:
URL: https://github.com/apache/fineract/pull/2234#discussion_r841437260


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java:
##########
@@ -1637,6 +1658,10 @@ private String getUpdateSql(List<ResultsetColumnHeaderData> columnHeaders, final
                     }
                 }
                 sql += sqlGenerator.escape(key) + " = " + pValueWrite;
+            } else {
+                if (key.equalsIgnoreCase("updated_at")) {

Review Comment:
   Magic string here.



##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/api/DataTableApiConstant.java:
##########
@@ -34,4 +34,25 @@ private DataTableApiConstant() {
     public static final String localParamName = "locale";
     public static final String DATATABLE_RESOURCE_NAME = "dataTables";
 
+    public static final String createdAtFieldName = "created_at";

Review Comment:
   This naming is not comforming the Java styling standards.
   `
   The names of variables declared class constants and of ANSI constants should be all uppercase with words separated by underscores ("_"). (ANSI constants should be avoided, for ease of debugging.)` - https://www.oracle.com/java/technologies/javase/codeconventions-namingconventions.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org