You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Patrick Reilly <pa...@gmail.com> on 2014/08/29 19:19:04 UTC
Review Request 25192: Switch [libprocess] to using compiler
intrinsics for unreachable, exit, and abort
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25192/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1744
https://issues.apache.org/jira/browse/MESOS-1744
Repository: mesos-git
Description
-------
Use compiler intrinsics for unreachable, exit, and abort
Makes the functions not need to pretend to return something while
still silencing the compiler warnings.
Diffs
-----
3rdparty/libprocess/src/process.cpp 3ac56c7
3rdparty/libprocess/src/subprocess.cpp 5b92200
Diff: https://reviews.apache.org/r/25192/diff/
Testing
-------
This is currently a work in progress, (WIP)
Thanks,
Patrick Reilly
Re: Review Request 25192: Switch [libprocess] to using compiler
intrinsics for unreachable, exit, and abort
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25192/#review52507
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On Sept. 5, 2014, 2 p.m., Patrick Reilly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25192/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2014, 2 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
>
>
> Bugs: MESOS-1744
> https://issues.apache.org/jira/browse/MESOS-1744
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Use compiler intrinsics for unreachable, exit, and abort
> Makes the functions not need to pretend to return something while
> still silencing the compiler warnings.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 3ac56c7
> 3rdparty/libprocess/src/subprocess.cpp 5b92200
>
> Diff: https://reviews.apache.org/r/25192/diff/
>
>
> Testing
> -------
>
> Make check runs.
>
>
> Thanks,
>
> Patrick Reilly
>
>
Re: Review Request 25192: Switch [libprocess] to using compiler
intrinsics for unreachable, exit, and abort
Posted by Patrick Reilly <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25192/
-----------------------------------------------------------
(Updated Sept. 5, 2014, 2 p.m.)
Review request for mesos, Benjamin Hindman and Dominic Hamon.
Changes
-------
added dependency
Bugs: MESOS-1744
https://issues.apache.org/jira/browse/MESOS-1744
Repository: mesos-git
Description
-------
Use compiler intrinsics for unreachable, exit, and abort
Makes the functions not need to pretend to return something while
still silencing the compiler warnings.
Diffs
-----
3rdparty/libprocess/src/process.cpp 3ac56c7
3rdparty/libprocess/src/subprocess.cpp 5b92200
Diff: https://reviews.apache.org/r/25192/diff/
Testing
-------
Make check runs.
Thanks,
Patrick Reilly
Re: Review Request 25192: Switch [libprocess] to using compiler
intrinsics for unreachable, exit, and abort
Posted by Patrick Reilly <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25192/
-----------------------------------------------------------
(Updated Aug. 29, 2014, 5:54 p.m.)
Review request for mesos, Benjamin Hindman and Dominic Hamon.
Changes
-------
Adding Dominic Hamon as reviewer.
Bugs: MESOS-1744
https://issues.apache.org/jira/browse/MESOS-1744
Repository: mesos-git
Description
-------
Use compiler intrinsics for unreachable, exit, and abort
Makes the functions not need to pretend to return something while
still silencing the compiler warnings.
Diffs
-----
3rdparty/libprocess/src/process.cpp 3ac56c7
3rdparty/libprocess/src/subprocess.cpp 5b92200
Diff: https://reviews.apache.org/r/25192/diff/
Testing
-------
Make check runs.
Thanks,
Patrick Reilly
Re: Review Request 25192: Switch [libprocess] to using compiler
intrinsics for unreachable, exit, and abort
Posted by Patrick Reilly <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25192/
-----------------------------------------------------------
(Updated Aug. 29, 2014, 5:51 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Make check runs.
Bugs: MESOS-1744
https://issues.apache.org/jira/browse/MESOS-1744
Repository: mesos-git
Description
-------
Use compiler intrinsics for unreachable, exit, and abort
Makes the functions not need to pretend to return something while
still silencing the compiler warnings.
Diffs
-----
3rdparty/libprocess/src/process.cpp 3ac56c7
3rdparty/libprocess/src/subprocess.cpp 5b92200
Diff: https://reviews.apache.org/r/25192/diff/
Testing (updated)
-------
Make check runs.
Thanks,
Patrick Reilly