You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@druid.apache.org by GitBox <gi...@apache.org> on 2018/07/10 14:43:27 UTC

[GitHub] leventov commented on a change in pull request #5980: Various changes about druid-services module

leventov commented on a change in pull request #5980: Various changes about druid-services module
URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201367693
 
 

 ##########
 File path: server/src/test/java/io/druid/initialization/InitializationTest.java
 ##########
 @@ -454,8 +454,8 @@ public void testExtensionsWithSameDirName() throws Exception
     final ClassLoader classLoader1 = Initialization.getClassLoaderForExtension(extension1, false);
     final ClassLoader classLoader2 = Initialization.getClassLoaderForExtension(extension2, false);
 
-    Assert.assertArrayEquals(new URL[]{jar1.toURL()}, ((URLClassLoader) classLoader1).getURLs());
-    Assert.assertArrayEquals(new URL[]{jar2.toURL()}, ((URLClassLoader) classLoader2).getURLs());
+    Assert.assertArrayEquals(new URL[]{jar1.toURI().toURL()}, ((URLClassLoader) classLoader1).getURLs());
 
 Review comment:
   Why this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
For additional commands, e-mail: dev-help@druid.apache.org