[jira] [Commented] (HBASE-14989) Implementation of Mutation.getWriteToWAL() is backwards

["Enis Soztutar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059418#comment-15059418 ] 

Enis Soztutar commented on HBASE-14989:
---------------------------------------

Yep, it should be {{!=}} instead of {{==}}. 

> Implementation of Mutation.getWriteToWAL() is backwards
> -------------------------------------------------------
>
>                 Key: HBASE-14989
>                 URL: https://issues.apache.org/jira/browse/HBASE-14989
>             Project: HBase
>          Issue Type: Bug
>            Reporter: James Taylor
>             Fix For: 1.2.0, 1.3.0, 1.1.4, 0.98.17, 1.0.4
>
>
> The implementation of the deprecated getWriteToWAL is backwards. It should return true if this.durability == Durability.SYNC_WAL:
> {code}
> /**
>    * @deprecated Use {@link #getDurability()} instead.
>    * @return true if edits should be applied to WAL, false if not
>    */
>   @Deprecated
>   public boolean getWriteToWAL() {
>     return this.durability == Durability.SKIP_WAL;
>   }
> {code}
> For example, if mutation.durability is Durability.SYNC_WAL and the following code is called {{clonedMutation.setWriteToWAL(mutation.getWriteToWAL())}}, it will disable writing to the WAL for clonedMutation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)