You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2020/11/10 21:04:11 UTC

[GitHub] [systemds] mboehm7 commented on pull request #1023: [WIP][SYSTEMDS-2625]: Cleanup GMM [SYSTEMDS-200] with builtin for LogSumExp

mboehm7 commented on pull request #1023:
URL: https://github.com/apache/systemds/pull/1023#issuecomment-724965141


   Thanks for the cleanup @Shafaq-Siddiqi - when finalizing the rework, could you please also have a look into (1) making the default number of components consistent with the documentation (1 vs 3), and (2) add tests with default configurations but more than one component (right now it fails for me with dimension mismatches with n=10 but runs fine with n=1). Once this PR is out of WIP status, I'll have a look and merge it in.   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org