You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by iBuddha <gi...@git.apache.org> on 2014/11/27 11:17:03 UTC
[GitHub] storm pull request: update PartitionManager.java
GitHub user iBuddha opened a pull request:
https://github.com/apache/storm/pull/331
update PartitionManager.java
fix wrong output in log when committed offset is too far behind latest offset
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iBuddha/storm patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/331.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #331
----
commit b82696ccb0bdd071d7ab5aa99276bdf4f82e9130
Author: hs <pe...@gmail.com>
Date: 2014-11-27T10:16:23Z
update PartitionManager.java
fix wrong output in log when committed offset is too far behind latest offset
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: update PartitionManager.java
Posted by iBuddha <gi...@git.apache.org>.
Github user iBuddha commented on the pull request:
https://github.com/apache/storm/pull/331#issuecomment-79609715
@d2r Sorry, my description "behind lastest offset" is not corrent. It should be "currentOffset", "currentOffset" could be other offset besides latest. But "currentOffset" could still be confused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: update PartitionManager.java
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/331#issuecomment-75583629
Created [STORM-685](https://issues.apache.org/jira/browse/STORM-685) for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: update PartitionManager.java
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/331#issuecomment-75586158
@iBuddha, thanks. I merged this to master.
Post your name if you would like it in the contributors list along with your github id.
If you would like attribution in STORM-685 on JIRA, please post your JIRA user name too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: update PartitionManager.java
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/331
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: update PartitionManager.java
Posted by Parth-Brahmbhatt <gi...@git.apache.org>.
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/331#issuecomment-72499073
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: update PartitionManager.java
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/331#issuecomment-67103228
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---