[GitHub] [hudi] danny0405 commented on a diff in pull request #9324: [HUDI-6619] [WIP] Fix hudi-integ-test-bundle dependency on jackson jsk310 package.

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #9324:
URL: https://github.com/apache/hudi/pull/9324#discussion_r1282536263


##########
pom.xml:
##########
@@ -98,8 +98,6 @@
     <fasterxml.jackson.databind.version>${fasterxml.spark3.version}</fasterxml.jackson.databind.version>
     <fasterxml.jackson.module.scala.version>${fasterxml.spark3.version}</fasterxml.jackson.module.scala.version>
     <fasterxml.jackson.dataformat.yaml.version>${fasterxml.spark3.version}</fasterxml.jackson.dataformat.yaml.version>
-    <!-- NOTE: By default we're not including JSR310 module for Jackson since Spark >= 3.x is bundling it anyway -->
-    <fasterxml.jackson.datatype.jsr310.module/>

Review Comment:
   @amrishlal You are right, if Hudi bundle jar shade the class anyway, we should always include the jar in the bundle, or any reference to the JSR class could encounter class not found exception.
   
   Another choice is we do not shade the JSR clazz, do we need a shade here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org