You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "jacek-lewandowski (via GitHub)" <gi...@apache.org> on 2023/06/28 12:21:01 UTC
[GitHub] [cassandra-dtest] jacek-lewandowski opened a new pull request, #224: Fix native_transport_ssl_test.py::TestNativeTransportSSL::test_connect_to_ssl
jacek-lewandowski opened a new pull request, #224:
URL: https://github.com/apache/cassandra-dtest/pull/224
With the change in Netty, namely https://github.com/netty/netty/pull/13314, it throws NotSslRecordException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] driftx commented on a diff in pull request #224: Fix native_transport_ssl_test.py::TestNativeTransportSSL::test_connect_to_ssl
Posted by "driftx (via GitHub)" <gi...@apache.org>.
driftx commented on code in PR #224:
URL: https://github.com/apache/cassandra-dtest/pull/224#discussion_r1245235733
##########
native_transport_ssl_test.py:
##########
@@ -40,7 +40,7 @@ def test_connect_to_ssl(self):
except NoHostAvailable:
pass
- if cluster.version() >= '4.0':
+ if cluster.version() >= '4.0' and cluster.version() < '5.0':
Review Comment:
If NotSslRecordException is being thrown we should assert that happens in 5.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] jacek-lewandowski commented on a diff in pull request #224: Fix native_transport_ssl_test.py::TestNativeTransportSSL::test_connect_to_ssl
Posted by "jacek-lewandowski (via GitHub)" <gi...@apache.org>.
jacek-lewandowski commented on code in PR #224:
URL: https://github.com/apache/cassandra-dtest/pull/224#discussion_r1245354388
##########
native_transport_ssl_test.py:
##########
@@ -40,7 +40,7 @@ def test_connect_to_ssl(self):
except NoHostAvailable:
pass
- if cluster.version() >= '4.0':
+ if cluster.version() >= '4.0' and cluster.version() < '5.0':
Review Comment:
there is "else" block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] jacek-lewandowski commented on pull request #224: Fix native_transport_ssl_test.py::TestNativeTransportSSL::test_connect_to_ssl
Posted by "jacek-lewandowski (via GitHub)" <gi...@apache.org>.
jacek-lewandowski commented on PR #224:
URL: https://github.com/apache/cassandra-dtest/pull/224#issuecomment-1635761575
renamed branch https://github.com/apache/cassandra-dtest/pull/226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] jacek-lewandowski closed pull request #224: Fix native_transport_ssl_test.py::TestNativeTransportSSL::test_connect_to_ssl
Posted by "jacek-lewandowski (via GitHub)" <gi...@apache.org>.
jacek-lewandowski closed pull request #224: Fix native_transport_ssl_test.py::TestNativeTransportSSL::test_connect_to_ssl
URL: https://github.com/apache/cassandra-dtest/pull/224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org