You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@syncope.apache.org by GitBox <gi...@apache.org> on 2022/05/31 08:56:34 UTC

[GitHub] [syncope] ilgrosso commented on a diff in pull request #348: SYNCOPE-1680: support Simple MFA for WA

ilgrosso commented on code in PR #348:
URL: https://github.com/apache/syncope/pull/348#discussion_r885380014


##########
core/persistence-jpa-json/src/test/resources/domains/MasterContent.xml:
##########
@@ -69,6 +69,8 @@ under the License.
               description="JDBC auth module" jsonConf='{"_class":"org.apache.syncope.common.lib.auth.JDBCAuthModuleConf","sql":"SELECT * FROM users_table WHERE name=?", "fieldPassword": "password"}'/>
   <AuthModule id="DefaultGoogleMfaAuthModule"
               description="Google Mfa auth module" jsonConf='{"_class":"org.apache.syncope.common.lib.auth.GoogleMfaAuthModuleConf","codeDigits":6,"issuer":"SyncopeTest", "label":"SyncopeTest", "timeStepSize":30, "windowSize":3}'/>
+  <AuthModule id="SimpleMfaAuthModule"

Review Comment:
   Just to stay aligned with others, `id` should be `DefaultSimpleMfaAuthModule`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org