You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Andrei Pozolotin (JIRA)" <ji...@apache.org> on 2012/08/21 20:54:38 UTC
[jira] [Created] (KARAF-1752) hard coded features uri in features
deployer feature discovery
Andrei Pozolotin created KARAF-1752:
---------------------------------------
Summary: hard coded features uri in features deployer feature discovery
Key: KARAF-1752
URL: https://issues.apache.org/jira/browse/KARAF-1752
Project: Karaf
Issue Type: Bug
Reporter: Andrei Pozolotin
changes
https://github.com/carrot-garden/carrot-apache-karaf/commit/9388a04fc9ecd9cddc3f4651e3f5e1c1c12de619
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1752) hard coded features uri in features
deployer feature discovery
Posted by "Andrei Pozolotin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439017#comment-13439017 ]
Andrei Pozolotin commented on KARAF-1752:
-----------------------------------------
on the other hand, uri validation is overkill and does not really help;
instead, just try to unmarshal xml into a bean,
return true on success, false on parser exception
> hard coded features uri in features deployer feature discovery
> --------------------------------------------------------------
>
> Key: KARAF-1752
> URL: https://issues.apache.org/jira/browse/KARAF-1752
> Project: Karaf
> Issue Type: Bug
> Reporter: Andrei Pozolotin
> Attachments: 0001-fix-hard-coded-features-uri-in-features-deployer.patch
>
>
> changes
> https://github.com/carrot-garden/carrot-apache-karaf/commit/9388a04fc9ecd9cddc3f4651e3f5e1c1c12de619
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1752) hard coded features uri in features
deployer feature discovery
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440953#comment-13440953 ]
Andreas Pieber commented on KARAF-1752:
---------------------------------------
Hey Andrei,
your patches KARAF-1738 and KARAF-1752 had been applied to the master. Would you mind to also give the backport to 2.3 a shot?
Thx again and kind regards,
Andreas
> hard coded features uri in features deployer feature discovery
> --------------------------------------------------------------
>
> Key: KARAF-1752
> URL: https://issues.apache.org/jira/browse/KARAF-1752
> Project: Karaf
> Issue Type: Improvement
> Reporter: Andrei Pozolotin
> Assignee: Andreas Pieber
> Fix For: 2.3.0, 3.0.0.RC1
>
> Attachments: 0001-fix-hard-coded-features-uri-in-features-deployer.patch
>
>
> changes
> https://github.com/carrot-garden/carrot-apache-karaf/commit/9388a04fc9ecd9cddc3f4651e3f5e1c1c12de619
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1752) hard coded features uri in features
deployer feature discovery
Posted by "Andrei Pozolotin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Pozolotin updated KARAF-1752:
------------------------------------
Attachment: 0001-fix-hard-coded-features-uri-in-features-deployer.patch
> hard coded features uri in features deployer feature discovery
> --------------------------------------------------------------
>
> Key: KARAF-1752
> URL: https://issues.apache.org/jira/browse/KARAF-1752
> Project: Karaf
> Issue Type: Bug
> Reporter: Andrei Pozolotin
> Attachments: 0001-fix-hard-coded-features-uri-in-features-deployer.patch
>
>
> changes
> https://github.com/carrot-garden/carrot-apache-karaf/commit/9388a04fc9ecd9cddc3f4651e3f5e1c1c12de619
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1752) hard coded features uri in features
deployer feature discovery
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440952#comment-13440952 ]
Andreas Pieber commented on KARAF-1752:
---------------------------------------
Committed r1376824
M tooling/karaf-maven-plugin/src/test/java/org/apache/karaf/tooling/features/GenerateDescriptorMojoTest.java
M deployer/features/src/main/java/org/apache/karaf/deployer/features/FeatureDeploymentListener.java
D features/core/src/main/java/org/apache/karaf/features/internal/FeaturesNamespaces.java
M features/core/src/main/java/org/apache/karaf/features/internal/model/JaxbUtil.java
M features/core/src/main/java/org/apache/karaf/features/internal/model/package-info.java
M features/core/src/main/java/org/apache/karaf/features/internal/FeatureValidationUtil.java
A features/core/src/main/java/org/apache/karaf/features/FeaturesNamespaces.java
W: -empty_dir: karaf/trunk/features/core/src/main/java/org/apache/karaf/features/internal/FeaturesNamespaces.java
r1376824 = b78b666ca484aaf4ca997a3cd7a5f8b649943605 (refs/remotes/origin/trunk)
> hard coded features uri in features deployer feature discovery
> --------------------------------------------------------------
>
> Key: KARAF-1752
> URL: https://issues.apache.org/jira/browse/KARAF-1752
> Project: Karaf
> Issue Type: Improvement
> Reporter: Andrei Pozolotin
> Assignee: Andreas Pieber
> Fix For: 2.3.0, 3.0.0.RC1
>
> Attachments: 0001-fix-hard-coded-features-uri-in-features-deployer.patch
>
>
> changes
> https://github.com/carrot-garden/carrot-apache-karaf/commit/9388a04fc9ecd9cddc3f4651e3f5e1c1c12de619
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1752) hard coded features uri in features
deployer feature discovery
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber updated KARAF-1752:
----------------------------------
Issue Type: Improvement (was: Bug)
I wouldn't call it a bug to have it hardcoded; rather an improvement to get rid of it
> hard coded features uri in features deployer feature discovery
> --------------------------------------------------------------
>
> Key: KARAF-1752
> URL: https://issues.apache.org/jira/browse/KARAF-1752
> Project: Karaf
> Issue Type: Improvement
> Reporter: Andrei Pozolotin
> Assignee: Andreas Pieber
> Fix For: 2.3.0, 3.0.0.RC1
>
> Attachments: 0001-fix-hard-coded-features-uri-in-features-deployer.patch
>
>
> changes
> https://github.com/carrot-garden/carrot-apache-karaf/commit/9388a04fc9ecd9cddc3f4651e3f5e1c1c12de619
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1752) hard coded features uri in features
deployer feature discovery
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber updated KARAF-1752:
----------------------------------
Fix Version/s: 3.0.0.RC1
2.3.0
> hard coded features uri in features deployer feature discovery
> --------------------------------------------------------------
>
> Key: KARAF-1752
> URL: https://issues.apache.org/jira/browse/KARAF-1752
> Project: Karaf
> Issue Type: Bug
> Reporter: Andrei Pozolotin
> Assignee: Andreas Pieber
> Fix For: 2.3.0, 3.0.0.RC1
>
> Attachments: 0001-fix-hard-coded-features-uri-in-features-deployer.patch
>
>
> changes
> https://github.com/carrot-garden/carrot-apache-karaf/commit/9388a04fc9ecd9cddc3f4651e3f5e1c1c12de619
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (KARAF-1752) hard coded features uri in features
deployer feature discovery
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber resolved KARAF-1752.
-----------------------------------
Resolution: Fixed
Also applied to 2.3.x
Committed r1395904
M deployer/features/src/main/java/org/apache/karaf/deployer/features/FeatureDeploymentListener.java
M tooling/features-maven-plugin/src/test/java/org/apache/karaf/tooling/features/GenerateFeaturesXmlMojoTest.java
A tooling/features-maven-plugin/src/test/resources/features-01.xml
M tooling/features-maven-plugin/src/main/java/org/apache/karaf/tooling/features/GenerateFeaturesXmlMojo.java
M features/core/src/main/java/org/apache/karaf/features/internal/FeatureValidationUtil.java
A features/core/src/main/java/org/apache/karaf/features/FeaturesNamespaces.java
A features/core/src/main/resources/org/apache/karaf/features/karaf-features-1.1.0.xsd
r1395904 = 6330333882857f5ba3052cdf70dd0aebd5b3bcf8 (refs/remotes/origin/karaf-2.3.x)
> hard coded features uri in features deployer feature discovery
> --------------------------------------------------------------
>
> Key: KARAF-1752
> URL: https://issues.apache.org/jira/browse/KARAF-1752
> Project: Karaf
> Issue Type: Improvement
> Reporter: Andrei Pozolotin
> Assignee: Andreas Pieber
> Fix For: 2.3.0, 3.0.0.RC1
>
> Attachments: 0001-back-port-KARAF-1738-KARAF-1752.patch.txt, 0001-fix-hard-coded-features-uri-in-features-deployer.patch
>
>
> changes
> https://github.com/carrot-garden/carrot-apache-karaf/commit/9388a04fc9ecd9cddc3f4651e3f5e1c1c12de619
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1752) hard coded features uri in features
deployer feature discovery
Posted by "Andrei Pozolotin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438955#comment-13438955 ]
Andrei Pozolotin commented on KARAF-1752:
-----------------------------------------
probably should move isKnownFeaturesURI() into features.core static util class
> hard coded features uri in features deployer feature discovery
> --------------------------------------------------------------
>
> Key: KARAF-1752
> URL: https://issues.apache.org/jira/browse/KARAF-1752
> Project: Karaf
> Issue Type: Bug
> Reporter: Andrei Pozolotin
> Attachments: 0001-fix-hard-coded-features-uri-in-features-deployer.patch
>
>
> changes
> https://github.com/carrot-garden/carrot-apache-karaf/commit/9388a04fc9ecd9cddc3f4651e3f5e1c1c12de619
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (KARAF-1752) hard coded features uri in features
deployer feature discovery
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber reassigned KARAF-1752:
-------------------------------------
Assignee: Andreas Pieber
> hard coded features uri in features deployer feature discovery
> --------------------------------------------------------------
>
> Key: KARAF-1752
> URL: https://issues.apache.org/jira/browse/KARAF-1752
> Project: Karaf
> Issue Type: Bug
> Reporter: Andrei Pozolotin
> Assignee: Andreas Pieber
> Attachments: 0001-fix-hard-coded-features-uri-in-features-deployer.patch
>
>
> changes
> https://github.com/carrot-garden/carrot-apache-karaf/commit/9388a04fc9ecd9cddc3f4651e3f5e1c1c12de619
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1752) hard coded features uri in features
deployer feature discovery
Posted by "Andrei Pozolotin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438942#comment-13438942 ]
Andrei Pozolotin commented on KARAF-1752:
-----------------------------------------
problem: current FeatureDeploymentListener will accept only v. 1.0.0 uri
> hard coded features uri in features deployer feature discovery
> --------------------------------------------------------------
>
> Key: KARAF-1752
> URL: https://issues.apache.org/jira/browse/KARAF-1752
> Project: Karaf
> Issue Type: Bug
> Reporter: Andrei Pozolotin
> Attachments: 0001-fix-hard-coded-features-uri-in-features-deployer.patch
>
>
> changes
> https://github.com/carrot-garden/carrot-apache-karaf/commit/9388a04fc9ecd9cddc3f4651e3f5e1c1c12de619
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (KARAF-1752) hard coded features uri in
features deployer feature discovery
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on KARAF-1752 started by Andreas Pieber.
> hard coded features uri in features deployer feature discovery
> --------------------------------------------------------------
>
> Key: KARAF-1752
> URL: https://issues.apache.org/jira/browse/KARAF-1752
> Project: Karaf
> Issue Type: Bug
> Reporter: Andrei Pozolotin
> Assignee: Andreas Pieber
> Attachments: 0001-fix-hard-coded-features-uri-in-features-deployer.patch
>
>
> changes
> https://github.com/carrot-garden/carrot-apache-karaf/commit/9388a04fc9ecd9cddc3f4651e3f5e1c1c12de619
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira