You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "jihuayu (via GitHub)" <gi...@apache.org> on 2024/08/03 11:21:16 UTC
[PR] Replace `docker-compose` with `docker compose` [kvrocks-controller]
jihuayu opened a new pull request, #198:
URL: https://github.com/apache/kvrocks-controller/pull/198
The current GitHub Action env `ubuntu-latest` don't have the `docker-compose` command. I have replaced `docker-compose` with `docker compose`.
See https://github.com/apache/kvrocks-controller/actions/runs/10227442375/job/28298937539?pr=197#step:6:5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Replace `docker-compose` with `docker compose` [kvrocks-controller]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #198:
URL: https://github.com/apache/kvrocks-controller/pull/198#issuecomment-2266682394
## [Codecov](https://app.codecov.io/gh/apache/kvrocks-controller/pull/198?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 57.31%. Comparing base [(`f4f3be0`)](https://app.codecov.io/gh/apache/kvrocks-controller/commit/f4f3be08bcda9aa2d9b7ea6e4cc5169edc1942f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`eecd257`)](https://app.codecov.io/gh/apache/kvrocks-controller/commit/eecd257f047f0f9bb3827935206bf4a4798a5d27?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 6 commits behind head on unstable.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## unstable #198 +/- ##
=============================================
+ Coverage 43.35% 57.31% +13.95%
=============================================
Files 37 20 -17
Lines 2973 2024 -949
=============================================
- Hits 1289 1160 -129
+ Misses 1544 727 -817
+ Partials 140 137 -3
```
| [Flag](https://app.codecov.io/gh/apache/kvrocks-controller/pull/198/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [unittests](https://app.codecov.io/gh/apache/kvrocks-controller/pull/198/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.31% <ø> (+13.95%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kvrocks-controller/pull/198?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Replace `docker-compose` with `docker compose` [kvrocks-controller]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu merged PR #198:
URL: https://github.com/apache/kvrocks-controller/pull/198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org