You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/30 02:32:40 UTC
[GitHub] [flink] fishzhe opened a new pull request #12413: [FLINK-16198][core] Fix FileUtilsTest fails on MacOS
fishzhe opened a new pull request #12413:
URL: https://github.com/apache/flink/pull/12413
## What is the purpose of the change
Fix FileUtilsTest fails on MacOS
## Brief change log
-*Fix concurrent delete failure on MacOS*
-*Fix relative compression path test failure*
## Verifying this change
*(Please pick either of the following options)*
This change is already covered by existing tests, such as *(FileUtilsTest.)*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no) no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) no
- The serializers: (yes / no / don't know) no
- The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know) no
- The S3 file system connector: (yes / no / don't know) no
## Documentation
- Does this pull request introduce a new feature? (yes / no) no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12413: [FLINK-16198][core] Fix FileUtilsTest fails on MacOS
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12413:
URL: https://github.com/apache/flink/pull/12413#issuecomment-641854619
Merged. 👌
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fishzhe edited a comment on pull request #12413: [FLINK-16198][core] Fix FileUtilsTest fails on MacOS
Posted by GitBox <gi...@apache.org>.
fishzhe edited a comment on pull request #12413:
URL: https://github.com/apache/flink/pull/12413#issuecomment-641470318
> Running this on macOS fails `testCompressionOnRelativePath`
Addressed this comment in the latest commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12413: [FLINK-16198][core] Fix FileUtilsTest fails on MacOS
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12413:
URL: https://github.com/apache/flink/pull/12413#issuecomment-636264630
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9495b0c78ae7f16e5f5fa0c0e7baa265942b742f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2472",
"triggerID" : "9495b0c78ae7f16e5f5fa0c0e7baa265942b742f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9495b0c78ae7f16e5f5fa0c0e7baa265942b742f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2472)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12413: [FLINK-16198][core] Fix FileUtilsTest fails on MacOS
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12413:
URL: https://github.com/apache/flink/pull/12413#issuecomment-636264630
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9495b0c78ae7f16e5f5fa0c0e7baa265942b742f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2472",
"triggerID" : "9495b0c78ae7f16e5f5fa0c0e7baa265942b742f",
"triggerType" : "PUSH"
}, {
"hash" : "7e26193381e3394db486b93d6c6a75b3828a1f09",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3092",
"triggerID" : "7e26193381e3394db486b93d6c6a75b3828a1f09",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9495b0c78ae7f16e5f5fa0c0e7baa265942b742f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2472)
* 7e26193381e3394db486b93d6c6a75b3828a1f09 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3092)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fishzhe commented on pull request #12413: [FLINK-16198][core] Fix FileUtilsTest fails on MacOS
Posted by GitBox <gi...@apache.org>.
fishzhe commented on pull request #12413:
URL: https://github.com/apache/flink/pull/12413#issuecomment-641470318
> Running this on macOS fails `testCompressionOnRelativePath`
Addressed this comment in the lated commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha closed pull request #12413: [FLINK-16198][core] Fix FileUtilsTest fails on MacOS
Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #12413:
URL: https://github.com/apache/flink/pull/12413
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12413: [FLINK-16198][core] Fix FileUtilsTest fails on MacOS
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12413:
URL: https://github.com/apache/flink/pull/12413#issuecomment-641853124
Thanks for the fix! I'll merge now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12413: [FLINK-16198][core] Fix FileUtilsTest fails on MacOS
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12413:
URL: https://github.com/apache/flink/pull/12413#issuecomment-636264630
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9495b0c78ae7f16e5f5fa0c0e7baa265942b742f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9495b0c78ae7f16e5f5fa0c0e7baa265942b742f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9495b0c78ae7f16e5f5fa0c0e7baa265942b742f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12413: [FLINK-16198][core] Fix FileUtilsTest fails on MacOS
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12413:
URL: https://github.com/apache/flink/pull/12413#issuecomment-636263706
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 9495b0c78ae7f16e5f5fa0c0e7baa265942b742f (Sat May 30 02:35:40 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12413: [FLINK-16198][core] Fix FileUtilsTest fails on MacOS
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12413:
URL: https://github.com/apache/flink/pull/12413#issuecomment-641195918
Running this on macOS fails `testCompressionOnRelativePath`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12413: [FLINK-16198][core] Fix FileUtilsTest fails on MacOS
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12413:
URL: https://github.com/apache/flink/pull/12413#issuecomment-636264630
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9495b0c78ae7f16e5f5fa0c0e7baa265942b742f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2472",
"triggerID" : "9495b0c78ae7f16e5f5fa0c0e7baa265942b742f",
"triggerType" : "PUSH"
}, {
"hash" : "7e26193381e3394db486b93d6c6a75b3828a1f09",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3092",
"triggerID" : "7e26193381e3394db486b93d6c6a75b3828a1f09",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7e26193381e3394db486b93d6c6a75b3828a1f09 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3092)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12413: [FLINK-16198][core] Fix FileUtilsTest fails on MacOS
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12413:
URL: https://github.com/apache/flink/pull/12413#issuecomment-636264630
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9495b0c78ae7f16e5f5fa0c0e7baa265942b742f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2472",
"triggerID" : "9495b0c78ae7f16e5f5fa0c0e7baa265942b742f",
"triggerType" : "PUSH"
}, {
"hash" : "7e26193381e3394db486b93d6c6a75b3828a1f09",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7e26193381e3394db486b93d6c6a75b3828a1f09",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9495b0c78ae7f16e5f5fa0c0e7baa265942b742f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2472)
* 7e26193381e3394db486b93d6c6a75b3828a1f09 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12413: [FLINK-16198][core] Fix FileUtilsTest fails on MacOS
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12413:
URL: https://github.com/apache/flink/pull/12413#issuecomment-636264630
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9495b0c78ae7f16e5f5fa0c0e7baa265942b742f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2472",
"triggerID" : "9495b0c78ae7f16e5f5fa0c0e7baa265942b742f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9495b0c78ae7f16e5f5fa0c0e7baa265942b742f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2472)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org