You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/22 19:52:11 UTC
[GitHub] [airflow] khalidmammadov opened a new pull request #19755: Capture container logs and upload as artficats when failed
khalidmammadov opened a new pull request #19755:
URL: https://github.com/apache/airflow/pull/19755
When CI containers crashed logs are not captured.
This will make default container output directory to `files/container_logs` that is uploaded as a next step in the CI when failed.
It will ensure that even containers are failed the latest progress from parallel runs are available for investigation.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] khalidmammadov closed pull request #19755: Capture container logs and upload as artficats when failed
Posted by GitBox <gi...@apache.org>.
khalidmammadov closed pull request #19755:
URL: https://github.com/apache/airflow/pull/19755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] khalidmammadov commented on pull request #19755: Capture container logs and upload as artficats when failed
Posted by GitBox <gi...@apache.org>.
khalidmammadov commented on pull request #19755:
URL: https://github.com/apache/airflow/pull/19755#issuecomment-980273487
It still prints into action logs (by monitoring command) and I was guided by below lines which is only activated when there is a failure. So, if it fails it will upload otherwise will work as normal.
[ - name: "Upload container logs"
uses: actions/upload-artifact@v2
if: failure()](https://github.com/apache/airflow/blob/20dc5b9aef66a9f2bed4e3ba652b385fb94b7e24/.github/workflows/ci.yml#L783-L785)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] khalidmammadov commented on pull request #19755: Capture container logs and upload as artficats when failed
Posted by GitBox <gi...@apache.org>.
khalidmammadov commented on pull request #19755:
URL: https://github.com/apache/airflow/pull/19755#issuecomment-977229339
This is not just for that issue were we looking at but in general I though it would be good to have this data as it also provides date and timestamps of the message that could be useful as well. Also, I think since it's not dependent from monitoring frequency every single log would be captured and made ready in case of a failure.
But if you think we have got this data and this change is not necessary then I will close, at the end of the day you know this CI pipeline better than anyone! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19755: Capture container logs and upload as artficats when failed
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19755:
URL: https://github.com/apache/airflow/pull/19755#issuecomment-977283386
Actually that might be a good one. But we need to make sure they are printed (further down) to the regular GitHub Actions log. The idea is that we should only upload artifacts when there is a failure and we should not duplicate what we manage to print to the log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org