You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/22 22:35:20 UTC

[GitHub] [beam] chamikaramj commented on a diff in pull request #24308: Adds GCP core dependency to the test expansion service

chamikaramj commented on code in PR #24308:
URL: https://github.com/apache/beam/pull/24308#discussion_r1029882071


##########
sdks/java/testing/expansion-service/build.gradle:
##########
@@ -27,6 +27,7 @@ ext.summary = """Testing Expansion Service used for executing cross-language tra
 
 
 dependencies {
+  implementation project(":sdks:java:extensions:google-cloud-platform-core")

Review Comment:
   Actually, just declaring this as a "testRuntimeOnly" dependency is adequate to include the classes in the shaded jar.,



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org