You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/12/03 12:25:22 UTC

[GitHub] vardancse commented on issue #4163: [AIRFLOW-3319] - KubernetsExecutor: Need in try_number in labels if getting them later

vardancse commented on issue #4163: [AIRFLOW-3319] - KubernetsExecutor: Need in try_number in  labels if getting them later
URL: https://github.com/apache/incubator-airflow/pull/4163#issuecomment-443692742
 
 
   @ashb @wyndhblb Change looks good to me. Was also thinking(nothing concerning though), do we really need error handling done here https://github.com/apache/incubator-airflow/pull/4163/files#diff-b1d8d65aeaa7d031dfe5b197d6c5aa69R464 as we've already placed try_number label in worker_configuration.py? 
   
   I also see another PR raised for the similar issue: https://github.com/apache/incubator-airflow/pull/4268
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services