You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/11 13:39:00 UTC

[jira] [Commented] (AIRFLOW-3675) The deprecated apiclient package name is used in a number of places

    [ https://issues.apache.org/jira/browse/AIRFLOW-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740384#comment-16740384 ] 

ASF GitHub Bot commented on AIRFLOW-3675:
-----------------------------------------

potiuk commented on pull request #4484: [AIRFLOW-3675] Use googlapiclient for google apis
URL: https://github.com/apache/airflow/pull/4484
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3675
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   The deprecated apiclient package name is used in a number of places.
   
   This commit changes it to googleapiclient and modifies the right
   packages to be used instead.
   
   ### Tests
   
   - [x] My PR  does not need extra testing for this extremely good reason - just running the old tests should be enough to verify it :).
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   No public API changes/documentation needed
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> The deprecated apiclient package name is used in a number of places
> -------------------------------------------------------------------
>
>                 Key: AIRFLOW-3675
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3675
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Jarek Potiuk
>            Assignee: Jarek Potiuk
>            Priority: Major
>
> This should be changed to the new googleapiclient name - which makes more sense and is 1-1 replacement (with proper sub-package naming). 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)