You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2020/08/06 07:17:40 UTC

[GitHub] [incubator-brpc] zyearn commented on pull request #1196: fix error when selective channel use consistent hash load balancer

zyearn commented on pull request #1196:
URL: https://github.com/apache/incubator-brpc/pull/1196#issuecomment-669753710


   这里的问题是由于在consistent hash中，用的是socket->remote_side作为hash key，而不是所有情况下remote_side都是有意义的（在selective_chan下并不能正确设置），所以是不是应该把remote_side换成另一个能全局唯一标识socket的变量作为hash key，例如socket->id().


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org